From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B00FC4332D for ; Tue, 12 Jan 2021 21:50:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E103D208B3 for ; Tue, 12 Jan 2021 21:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437947AbhALVek (ORCPT ); Tue, 12 Jan 2021 16:34:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437104AbhALVEH (ORCPT ); Tue, 12 Jan 2021 16:04:07 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36F18C061786 for ; Tue, 12 Jan 2021 13:03:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=WsOgljZN11s48vyCDI4F4Mld1I0ggb1VBYdNIdrE2J0=; b=l3Ljf04thYjGmN+3zqr/EYdgUN GjCuacKqOIEjIwqrBsWV3dnEojmmuVfYBKikIZjZTgmDW+K5v+6WPEcohu46nFwzhCulbfPhdk5eH kE+CFG+HZv5luCPTzlVlznC20ioaa4njS8rLvh/+4qk9S3YHFI0arguODPC3KAwuW3u7SXbFuSKIo KSD4LcjbOQRfAUJM0ci7tDUztR2fCIrI4UxfcN9mecJl5WIARfaGYgIXI4wyV1kasKGmcYuTFi3JB 423vL9vVpnvehuCgFZC3FzjxyYdp2siU9aB66q7lTFa6fixQ3xA28DqOoomOUJiFjZcFtfPQjYDtO Dtetf8yg==; Received: from [2601:1c0:6280:3f0::79df] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzQop-0001fP-Vt; Tue, 12 Jan 2021 21:03:12 +0000 Subject: Re: [PATCH v2 09/70] mm/mmap: Change find_vma_prev() to use maple tree To: "Liam R. Howlett" , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton , Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Jerome Glisse , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Rik van Riel , Peter Zijlstra References: <20210112161240.2024684-1-Liam.Howlett@Oracle.com> <20210112161240.2024684-10-Liam.Howlett@Oracle.com> From: Randy Dunlap Message-ID: <74b9865e-a807-cfa3-d099-ed1c5c1cea0c@infradead.org> Date: Tue, 12 Jan 2021 13:03:03 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210112161240.2024684-10-Liam.Howlett@Oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please see kernel-doc fixes below: On 1/12/21 8:11 AM, Liam R. Howlett wrote: > Change the implementation of find_vma_prev to use the new maple tree > data structure. > > Signed-off-by: Liam R. Howlett > --- > mm/mmap.c | 27 +++++++++++++++++---------- > 1 file changed, 17 insertions(+), 10 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index ab1cb0efc4c65..f123f9c97dfe8 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -2500,23 +2500,30 @@ struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr) > } > EXPORT_SYMBOL(find_vma); > > -/* > - * Same as find_vma, but also return a pointer to the previous VMA in *pprev. > +/** > + * find_vma_prev() - Find the VMA for a given address, or the next vma and > + * sets %pprev to the previous VMA, if any. * set @pprev > + * @mm The mm_struct to check * @mm: ... > + * @addr: The address > + * @pprev: The pointer to set to the previous VMA > + * > + * Returns: The VMA associated with @addr, or the next vma. > + * May return NULL in the case of no vma at addr or above. %NULL > */ > struct vm_area_struct * > find_vma_prev(struct mm_struct *mm, unsigned long addr, thanks. -- ~Randy