From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1D2C35242 for ; Mon, 17 Feb 2020 07:53:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB6F22064C for ; Mon, 17 Feb 2020 07:53:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726609AbgBQHx4 (ORCPT ); Mon, 17 Feb 2020 02:53:56 -0500 Received: from ivanoab7.miniserver.com ([37.128.132.42]:60426 "EHLO www.kot-begemot.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbgBQHx4 (ORCPT ); Mon, 17 Feb 2020 02:53:56 -0500 Received: from tun252.jain.kot-begemot.co.uk ([192.168.18.6] helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j3bE0-00077C-Qf; Mon, 17 Feb 2020 07:53:53 +0000 Received: from sleer.kot-begemot.co.uk ([192.168.3.72]) by jain.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j3bDy-0000Vm-LO; Mon, 17 Feb 2020 07:53:52 +0000 Subject: Re: [PATCH] um: vector: Avoid NULL ptr deference if transport is unset To: Sjoerd Simons , linux-um@lists.infradead.org Cc: Jeff Dike , Richard Weinberger , linux-kernel@vger.kernel.org References: <20200216213624.800463-1-sjoerd.simons@collabora.co.uk> From: Anton Ivanov Organization: Cambridge Greys Message-ID: <74c04f11-4b67-d1a7-7d05-197a229b245c@cambridgegreys.com> Date: Mon, 17 Feb 2020 07:53:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200216213624.800463-1-sjoerd.simons@collabora.co.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Clacks-Overhead: GNU Terry Pratchett Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/02/2020 21:36, Sjoerd Simons wrote: > When the transport option of a vec isn't set strncmp ends up being > called on a NULL pointer. Better not do that. > > Signed-off-by: Sjoerd Simons > > --- > > arch/um/drivers/vector_kern.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c > index 0ff86391f77d..ca90666c0b61 100644 > --- a/arch/um/drivers/vector_kern.c > +++ b/arch/um/drivers/vector_kern.c > @@ -198,6 +198,9 @@ static int get_transport_options(struct arglist *def) > long parsed; > int result = 0; > > + if (transport == NULL) > + return -EINVAL; > + > if (vector != NULL) { > if (kstrtoul(vector, 10, &parsed) == 0) { > if (parsed == 0) { > Acked-By: Anton Ivanov -- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/