From: Guenter Roeck <linux@roeck-us.net>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Oliver Neukum <oneukum@suse.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Bin Gao <bin.gao@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
badhri@google.com
Subject: Re: [PATHCv10 1/2] usb: USB Type-C connector class
Date: Tue, 15 Nov 2016 01:25:59 -0800 [thread overview]
Message-ID: <74c10d95-47b6-cc5d-eda0-056439db4ec7@roeck-us.net> (raw)
In-Reply-To: <20161115070754.GA26240@kroah.com>
On 11/14/2016 11:07 PM, Greg KH wrote:
> On Mon, Nov 14, 2016 at 12:46:50PM -0800, Guenter Roeck wrote:
>> On Mon, Nov 14, 2016 at 02:32:35PM +0200, Heikki Krogerus wrote:
>>> Hi Greg,
>>>
>>> On Mon, Nov 14, 2016 at 10:51:48AM +0100, Greg KH wrote:
>>>> On Mon, Sep 19, 2016 at 02:16:56PM +0300, Heikki Krogerus wrote:
>>>>> The purpose of USB Type-C connector class is to provide
>>>>> unified interface for the user space to get the status and
>>>>> basic information about USB Type-C connectors on a system,
>>>>> control over data role swapping, and when the port supports
>>>>> USB Power Delivery, also control over power role swapping
>>>>> and Alternate Modes.
>>>>>
>>>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>>> Tested-by: Guenter Roeck <linux@roeck-us.net>
>>>>> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>>>>> ---
>>>>> Documentation/ABI/testing/sysfs-class-typec | 218 ++++++
>>>>> Documentation/usb/typec.txt | 103 +++
>>>>> MAINTAINERS | 9 +
>>>>> drivers/usb/Kconfig | 2 +
>>>>> drivers/usb/Makefile | 2 +
>>>>> drivers/usb/typec/Kconfig | 7 +
>>>>> drivers/usb/typec/Makefile | 1 +
>>>>> drivers/usb/typec/typec.c | 1075 +++++++++++++++++++++++++++
>>>>> include/linux/usb/typec.h | 252 +++++++
>>>>> 9 files changed, 1669 insertions(+)
>>>>> create mode 100644 Documentation/ABI/testing/sysfs-class-typec
>>>>> create mode 100644 Documentation/usb/typec.txt
>>>>> create mode 100644 drivers/usb/typec/Kconfig
>>>>> create mode 100644 drivers/usb/typec/Makefile
>>>>> create mode 100644 drivers/usb/typec/typec.c
>>>>> create mode 100644 include/linux/usb/typec.h
>>>>
>> [ ... ]
>>
>>>>> +
>>>>> +int typec_connect(struct typec_port *port, struct typec_connection *con)
>>>>> +{
>>>>> + int ret;
>>>>> +
>>>>> + if (!con->partner && !con->cable)
>>>>> + return -EINVAL;
>>>>> +
>>>>> + port->connected = 1;
>>>>> + port->data_role = con->data_role;
>>>>> + port->pwr_role = con->pwr_role;
>>>>> + port->vconn_role = con->vconn_role;
>>>>> + port->pwr_opmode = con->pwr_opmode;
>>>>> +
>>>>> + kobject_uevent(&port->dev.kobj, KOBJ_CHANGE);
>>>>
>>>> This worries me. Who is listening for it? What will you do with it?
>>>> Shouldn't you just poll on an attribute file instead?
>>>
>>> Oliver! Did you need this or can we remove it?
>>>
>>> I remember I removed the "connected" attribute because you did not see
>>> any use for it at one point. I don't remember the reason exactly why?
>>>
>>
>> The Android team tells me that they are currently using the udev events
>> to track port role changes, and to detect presence of port partner.
>>
>> Also, there are plans to track changes on usbc*cable to differentiate
>> between cable attach vs. device being attached on the remote end.
>>
>> What is the problem with using kobject_uevent() and thus presumably
>> udev events ?
>
> It's not a "normal" thing to do and is pretty "heavy" to do. What does
> userspace do with that change event? Does it read specific attributes?
> What causes the event to happen in the kernel, is it really just a
> change in the specific object, or do new ones get added/removed?
>
> In short, document the heck out of this please so people know how to use
> it, and what is happening when the event happens.
>
Badhri,
can you clarify which events you are using in detail, and what for ?
Thanks,
Guenter
next prev parent reply other threads:[~2016-11-15 9:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 11:16 [PATHCv10 0/2] USB Type-C Connector class Heikki Krogerus
2016-09-19 11:16 ` [PATHCv10 1/2] usb: USB Type-C connector class Heikki Krogerus
2016-11-14 9:51 ` Greg KH
2016-11-14 12:32 ` Heikki Krogerus
2016-11-14 14:11 ` Greg KH
2016-11-14 14:39 ` Heikki Krogerus
2016-11-14 15:08 ` Greg KH
2016-11-14 14:34 ` Guenter Roeck
2016-11-16 8:47 ` Oliver Neukum
2016-11-14 20:46 ` Guenter Roeck
2016-11-15 7:07 ` Greg KH
2016-11-15 9:25 ` Guenter Roeck [this message]
2016-11-16 0:19 ` Badhri Jagan Sridharan
2016-11-16 9:30 ` Heikki Krogerus
2016-11-16 9:39 ` Oliver Neukum
2016-11-16 9:49 ` Greg KH
2016-11-16 11:09 ` Heikki Krogerus
2016-11-16 11:27 ` Oliver Neukum
2016-11-16 14:30 ` Badhri Jagan Sridharan
2016-11-16 14:43 ` Heikki Krogerus
2016-11-16 15:20 ` Heikki Krogerus
2016-11-16 15:25 ` Badhri Jagan Sridharan
2016-11-16 15:31 ` Greg KH
2016-11-17 8:28 ` Heikki Krogerus
2016-09-19 11:16 ` [PATHCv10 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus
2016-11-10 21:36 ` [PATHCv10 0/2] USB Type-C Connector class Guenter Roeck
2016-11-11 11:04 ` Heikki Krogerus
2016-11-14 7:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74c10d95-47b6-cc5d-eda0-056439db4ec7@roeck-us.net \
--to=linux@roeck-us.net \
--cc=badhri@google.com \
--cc=bin.gao@linux.intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).