From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Al Cooper <alcooperx@gmail.com>, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
Mathias Nyman <mathias.nyman@intel.com>
Subject: Re: [PATCH] usb: xhci: Error enumerating USB TV Tuner
Date: Mon, 9 Mar 2020 14:22:17 +0200 [thread overview]
Message-ID: <74c294a3-8eaa-a48e-3371-a7027d5aabd2@linux.intel.com> (raw)
In-Reply-To: <20200306160659.16319-1-alcooperx@gmail.com>
On 6.3.2020 18.06, Al Cooper wrote:
> Unable to complete the enumeration of a USB TV Tuner device.
>
> Per XHCI spec (4.6.5), the EP state field of the input context shall
> be cleared for a set address command. In the special case of an FS
> device that has "MaxPacketSize0 = 8", the Linux XHCI driver does
> not do this before evaluating the context. With an XHCI controller
> that checks the EP state field for parameter context error this
> causes a problem in cases such as the device getting reset again
> after enumeration.
>
> When that field is cleared, the problem does not occur.
>
> This was found and fixed by Sasi Kumar.
>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
> ---
> drivers/usb/host/xhci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index dbac0fa9748d..5f034e143082 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -1428,6 +1428,7 @@ static int xhci_check_maxpacket(struct xhci_hcd *xhci, unsigned int slot_id,
> xhci->devs[slot_id]->out_ctx, ep_index);
>
> ep_ctx = xhci_get_ep_ctx(xhci, command->in_ctx, ep_index);
> + ep_ctx->ep_info &= cpu_to_le32(~EP_STATE_MASK);/* must clear */
> ep_ctx->ep_info2 &= cpu_to_le32(~MAX_PACKET_MASK);
> ep_ctx->ep_info2 |= cpu_to_le32(MAX_PACKET(max_packet_size));
>
>
Thanks, nice catch.
If you agree I'd like to change the the subject of this patch to something like:
"xhci: Fix enumeration issue when setting actual max packet size for FS devices"
While looking at this it seems that the current EP_STATE_MASK is not correct either.
It should be 0x7 instead of 0xf.
-Mathias
next prev parent reply other threads:[~2020-03-09 12:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 16:06 [PATCH] usb: xhci: Error enumerating USB TV Tuner Al Cooper
2020-03-09 12:22 ` Mathias Nyman [this message]
2020-03-10 18:34 ` Alan Cooper
2020-03-11 7:31 ` Mathias Nyman
2020-03-11 11:40 ` Alan Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74c294a3-8eaa-a48e-3371-a7027d5aabd2@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=alcooperx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).