From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BCBDC433E1 for ; Mon, 22 Mar 2021 12:37:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3901619C8 for ; Mon, 22 Mar 2021 12:37:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229728AbhCVMgw (ORCPT ); Mon, 22 Mar 2021 08:36:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231403AbhCVMdO (ORCPT ); Mon, 22 Mar 2021 08:33:14 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA1ADC061762 for ; Mon, 22 Mar 2021 05:33:13 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id bf3so19121761edb.6 for ; Mon, 22 Mar 2021 05:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SVanQr0nOKD358IYkjRAx3PCoRE9oI5X2zMEqx499hk=; b=In/2zB5DflwheyajBKF2sx8W9MNDzsh1OSXWuUfKtL/FRN8c9FQQ2cj+JpRaMJ8aAU XCEdMl5E1nKXsJ7LPr/dtmRUfPx5+I1x5doeJjGnHJs2u9wPfhjKCteG52TK/mXsWmp0 r9Anh7nKKI7VMsuXAdYXcsCGpZElkzpp47nt0czliuc/sgnYDu/CCcQloeUW02Hubge7 sWrpe/oCUN6WhcZa9kKsbPAqAXLDiS1XaNnARw1txUwxLHGsZeVRD+wmAVt2sQW9eS55 UyTJMvhgC22uRmJJA3ffzwFbfulqEQ+Y37qGJg3epzU8Qv8Y9P3aSJ9V5kCcRG0/y2iv oQLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SVanQr0nOKD358IYkjRAx3PCoRE9oI5X2zMEqx499hk=; b=EPKgXC/GiHoSm2M+xcKebHTLIKoA+JCo0OjL8C73//3iKP32Joyx0aa6/73g8WPMwn bYO0MAMaXcA3H0QxYI9PfX+J8uyE8fmXMLpcKdgc87ltHuHykPGH1wCikVi1vGaq7EMd xGmVkeUstErn+gphlMBHqhrHNqL38r6Nz2SczPLQeud7vl37qrVaOp0euTP791bxbkUf udACpIVR2q3QCIOvzTYs0A2C4JBhrv2KpbAjao5HuqaNRy6Ce4y5tPQ02bbAzGg+tkJy Ahq6ew4oFs8juZYe8cTavHhgX3rQvPUJIhB7o4tg+cU4UddUMFrvsJGa5rLrqS3EyIw0 gdzA== X-Gm-Message-State: AOAM533kwPKLQ7Uh2NmFa/jml/xgZ6Scy5zqoyeB1OTHImkZY2IoEed1 GsSkp1BUW6zJ8YJ/RMGB4EFd7g== X-Google-Smtp-Source: ABdhPJzU8lxBAEHdWAbezgHwbSa71swddR2DYb7EY4LfoVvJcbMJx1acYwfadWxsyNH4XNxBLRVo6A== X-Received: by 2002:a50:f391:: with SMTP id g17mr25306211edm.26.1616416392520; Mon, 22 Mar 2021 05:33:12 -0700 (PDT) Received: from ?IPv6:2a02:768:2307:40d6::e05? ([2a02:768:2307:40d6::e05]) by smtp.gmail.com with ESMTPSA id t27sm9618783ejc.62.2021.03.22.05.33.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 05:33:12 -0700 (PDT) Subject: Re: [PATCH 03/13] PCI: xilinx: Convert to MSI domains To: Lorenzo Pieralisi , Marc Zyngier , michal.simek@xilinx.com Cc: Bjorn Helgaas , Frank Wunderlich , Thierry Reding , Thomas Gleixner , Rob Herring , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Thierry Reding , Jonathan Hunter , Ryder Lee , Marek Vasut , Yoshihiro Shimoda , Paul Walmsley , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org References: <20210225151023.3642391-1-maz@kernel.org> <20210225151023.3642391-4-maz@kernel.org> <20210322122100.GA11469@e121166-lin.cambridge.arm.com> From: Michal Simek Message-ID: <74cffc38-df12-7d92-1bfe-20eed4b60e86@monstr.eu> Date: Mon, 22 Mar 2021 13:33:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210322122100.GA11469@e121166-lin.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 3/22/21 1:21 PM, Lorenzo Pieralisi wrote: > On Thu, Feb 25, 2021 at 03:10:13PM +0000, Marc Zyngier wrote: >> In anticipation of the removal of the msi_controller structure, convert >> the ancient xilinx host controller driver to MSI domains. >> >> We end-up with the usual two domain structure, the top one being a >> generic PCI/MSI domain, the bottom one being xilinx-specific and handling >> the actual HW interrupt allocation. >> >> This allows us to fix some of the most appaling MSI programming, where >> the message programmed in the device is the virtual IRQ number instead >> of the allocated vector number. The allocator is also made safe with >> a mutex. This should allow support for MultiMSI, but I decided not to >> even try, since I cannot test it. >> >> Also take the opportunity to get rid of the cargo-culted memory allocation >> for the MSI capture address. *ANY* sufficiently aligned address should >> be good enough, so use the physical address of the xilinx_pcie_host >> structure instead. >> >> Signed-off-by: Marc Zyngier >> --- >> drivers/pci/controller/Kconfig | 2 +- >> drivers/pci/controller/pcie-xilinx.c | 238 +++++++++++---------------- >> 2 files changed, 96 insertions(+), 144 deletions(-) > > Michal, > > can you please test these changes or make sure someone does and report > back on the mailing list please ? > > I would like to merge this series for v5.13. I got just private response (not sure why) from Bharat March 5 that changes are fine. It means go ahead with it. Thanks, Michal