From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 566DCC433EF for ; Wed, 22 Sep 2021 06:29:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41CBC611B0 for ; Wed, 22 Sep 2021 06:29:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232777AbhIVGay (ORCPT ); Wed, 22 Sep 2021 02:30:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57108 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232753AbhIVGax (ORCPT ); Wed, 22 Sep 2021 02:30:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632292163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E/tHH9wLLtazV94QpN+BmGuu66vagS3lkpjDcUcpVzA=; b=PGPf9ZzB33LZyiZilg2aozwZm5TDj5p0O5vz/gJCSjvz+UFxd649DuOMY96TZ0C7Yhswar Jo7WK7EKH7drHXehvlque90NgI8miKqAqdhI8I3mYPRJ1+VBPU59VAOBjhjFTrRdyNQnyy WXSIXoeyFvkhHyhwswuM+UhVvVnYRvw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-219-rlf42m89PJC7NzJSU0wK7w-1; Wed, 22 Sep 2021 02:29:22 -0400 X-MC-Unique: rlf42m89PJC7NzJSU0wK7w-1 Received: by mail-wr1-f69.google.com with SMTP id z2-20020a5d4c82000000b0015b140e0562so1157345wrs.7 for ; Tue, 21 Sep 2021 23:29:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E/tHH9wLLtazV94QpN+BmGuu66vagS3lkpjDcUcpVzA=; b=BTiUyza22nA4nqG+bqy7KNAB06y0JXOiZQoAa5q8QNZX8nT9fW5S/mWTSU5HwbctaG RmZcU7W1EbpsE+uU3Dw7FjmL2hk+Jyc9xeTaqHCoS0DX62OmubiFtnLgzVSYfAErwpRI DH+IRsqiZuZI6RJw992YTdtb93KGmJDQv+atA7C7Fk0EfFQxZjltJaJXYWZjALScH7xX MZ8b2Kbns0nUraUIBPZJBdN6ZX/haXy6cECY2Mf7oRUDxUNJjXEPvbVJct5yOpGbYuJE iDq5TrnxzAU2vnbCTEHPnxYU6lohbYlp1ELEyNbcmo8+9QwJ5+w/LlLwx6EdjIfv07jH a81Q== X-Gm-Message-State: AOAM531NYjlBJA4qE/f1wHoGwfFQzO85XuUPj7+6SHZjkVUzBKpHQNu3 s2X3IwD+CyVruahMQPvVO8fj3N9brL85wPDOuJIGX/5wDsejtmojNlHNwMQgrUecLcJrLbmONFI Iqu1IyPI6EVFSuF3Wr+beqZtH X-Received: by 2002:a5d:64a7:: with SMTP id m7mr39506101wrp.171.1632292161047; Tue, 21 Sep 2021 23:29:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhBqcw62XwXR9WbHiblbcM9n6+4WHbybrr5/MkhCq7T4dnVdh+qdYz2KsHuqdWFBJH3F6z5Q== X-Received: by 2002:a5d:64a7:: with SMTP id m7mr39506073wrp.171.1632292160784; Tue, 21 Sep 2021 23:29:20 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n26sm4980232wmi.43.2021.09.21.23.29.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 23:29:20 -0700 (PDT) Subject: Re: [PATCH v3 16/16] perf: Drop guest callback (un)register stubs To: Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Marc Zyngier , Guo Ren , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Boris Ostrovsky , Juergen Gross Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Morse , Alexandru Elisei , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Artem Kashkanov , Like Xu , Zhu Lingshan References: <20210922000533.713300-1-seanjc@google.com> <20210922000533.713300-17-seanjc@google.com> From: Paolo Bonzini Message-ID: <74d2e94f-fbd3-522e-8fc5-da5a0a575838@redhat.com> Date: Wed, 22 Sep 2021 08:29:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210922000533.713300-17-seanjc@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/09/21 02:05, Sean Christopherson wrote: > Drop perf's stubs for (un)registering guest callbacks now that KVM > registration of callbacks is hidden behind GUEST_PERF_EVENTS=y. The only > other user is x86 XEN_PV, and x86 unconditionally selects PERF_EVENTS. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > include/linux/perf_event.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index d582dfeb4e20..20327d1046bb 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -1505,11 +1505,6 @@ perf_sw_event(u32 event_id, u64 nr, struct pt_regs *regs, u64 addr) { } > static inline void > perf_bp_event(struct perf_event *event, void *data) { } > > -static inline void perf_register_guest_info_callbacks > -(struct perf_guest_info_callbacks *cbs) { } > -static inline void perf_unregister_guest_info_callbacks > -(struct perf_guest_info_callbacks *cbs) { } > - > static inline void perf_event_mmap(struct vm_area_struct *vma) { } > > typedef int (perf_ksymbol_get_name_f)(char *name, int name_len, void *data); > Reviewed-by: Paolo Bonzini