From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C03E5C4BA3B for ; Thu, 27 Feb 2020 12:08:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 930F72467B for ; Thu, 27 Feb 2020 12:08:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728986AbgB0MIv (ORCPT ); Thu, 27 Feb 2020 07:08:51 -0500 Received: from foss.arm.com ([217.140.110.172]:49422 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728932AbgB0MIv (ORCPT ); Thu, 27 Feb 2020 07:08:51 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C2E151FB; Thu, 27 Feb 2020 04:08:50 -0800 (PST) Received: from [10.37.12.169] (unknown [10.37.12.169]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 062B73F73B; Thu, 27 Feb 2020 04:08:48 -0800 (PST) Subject: Re: [PATCH] sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA To: Valentin Schneider , linux-kernel@vger.kernel.org Cc: mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, mgorman@techsingularity.net References: <20200227110053.2514-1-lukasz.luba@arm.com> From: Lukasz Luba Message-ID: <74d75844-e710-6df8-30a9-acd440394c2e@arm.com> Date: Thu, 27 Feb 2020 12:08:46 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Valentin, On 2/27/20 11:04 AM, Valentin Schneider wrote: > Hi Lukasz, > > On 2/27/20 11:00 AM, Lukasz Luba wrote: >> Fix kernel build warning in kernel/sched/fair.c when CONFIG_SCHED_SMT is >> not set and CONFIG_NUMA_BALANCING is set. >> >> kernel/sched/fair.c:1524:20: warning: ‘test_idle_cores’ declared ‘static’ but never defined [-Wunused-function] >> > > I've sent a similar fix yesterday at: > > https://lore.kernel.org/lkml/20200226121244.7524-1-valentin.schneider@arm.com/ > I've missed it. You are referring in the commit message to wrong change (probably HEAD of that branch), while when you try to bisect, it will point you to ff7db0bf24db sched/numa: Prefer using an idle CPU as a migration target instead of comparing tasks I think Mel can simply resend the patches with correct build if Ingo is OK. If Mel would decide to go with extended approach of ifdefs, then maybe it's also good to put in there numa_idle_core(), which actually uses these test_idle_cores() and is_core_idle() Regards, Lukasz