From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940434AbdAGBaC convert rfc822-to-8bit (ORCPT ); Fri, 6 Jan 2017 20:30:02 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:41430 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbdAGB34 (ORCPT ); Fri, 6 Jan 2017 20:29:56 -0500 content-type: text/plain; charset="utf-8" in-reply-to: from: "Peter Senna Tschudin" X-Forward: 82.136.76.99 date: Sat, 07 Jan 2017 01:29:52 +0000 cc: "Mauro Carvalho Chehab" , "Archit Taneja" , =?utf-8?q?devicetree=40vger=2Ekernel=2Eorg?= , =?utf-8?q?heiko=40sntech=2Ede?= , "Greg Kroah-Hartman" , "David Miller" , =?utf-8?q?linux-arm-kernel=40lists=2Einfradead=2Eorg?= , "Martyn Welch" , "Guenter Roeck" , =?utf-8?q?kernel=40pengutronix=2Ede?= , "Kumar Gala" , =?utf-8?q?linux-kernel=40vger=2Ekernel=2Eorg?= , "David Airlie" , "Peter Senna Tschudin" , "Fabio Estevam" , martin.donnelly@ge.com, "Jiri Slaby" , "Thierry Reding" , "Mark Rutland" , "Enric Balletbo i Serra" , "Takashi Iwai" , "Philipp Zabel" , enric.balletbo@collabora.com, "Peter Senna Tschudin" , "Javier Martinez Canillas" , "Yakir Yang" , "Thierry Reding" , "Ian Campbell" , "Shawn Guo" , "dri-devel" , "Daniel Vetter" , "Russell King" , "Pawel Moll" , "Russell King" , "Andrew Morton" to: "Rob Herring" MIME-Version: 1.0 message-id: <74f0-58704480-5-27259840@173563636> subject: =?utf-8?q?Re=3A?==?utf-8?q?_=5BPATCH?= V7 =?utf-8?q?1=2F4=5D?= =?utf-8?q?_Documentation=2Fdevicetree=2Fbindings=3A?= =?utf-8?q?_b850v3=5Flvds=5Fdp?= User-Agent: SOGoMail 2.3.11 content-transfer-encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04 January, 2017 21:39 CET, Rob Herring wrote: > On Tue, Jan 3, 2017 at 5:34 PM, Peter Senna Tschudin > wrote: > > Hi Rob, > > > > Thank you for the review. > > > > On 03 January, 2017 23:51 CET, Rob Herring wrote: > > > >> On Sun, Jan 01, 2017 at 09:24:29PM +0100, Peter Senna Tschudin wrote: > >> > Devicetree bindings documentation for the GE B850v3 LVDS/DP++ > >> > display bridge. > >> > > >> > Cc: Martyn Welch > >> > Cc: Martin Donnelly > >> > Cc: Javier Martinez Canillas > >> > Cc: Enric Balletbo i Serra > >> > Cc: Philipp Zabel > >> > Cc: Rob Herring > >> > Cc: Fabio Estevam > >> > Signed-off-by: Peter Senna Tschudin > >> > --- > >> > There was an Acked-by from Rob Herring for V6, but I changed > >> > the bindings to use i2c_new_secondary_device() so I removed it from the commit > >> > message. > >> > > >> > .../devicetree/bindings/ge/b850v3-lvds-dp.txt | 39 ++++++++++++++++++++++ > >> > >> Generally, bindings are not organized by vendor. Put in > >> bindings/display/bridge/... instead. > > > > Will change that. > > > >> > >> > 1 file changed, 39 insertions(+) > >> > create mode 100644 Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt > >> > > >> > diff --git a/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt > >> > new file mode 100644 > >> > index 0000000..1bc6ebf > >> > --- /dev/null > >> > +++ b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt > >> > @@ -0,0 +1,39 @@ > >> > +Driver for GE B850v3 LVDS/DP++ display bridge > >> > + > >> > +Required properties: > >> > + - compatible : should be "ge,b850v3-lvds-dp". > >> > >> Isn't '-lvds-dp' redundant? The part# should be enough. > > > > b850v3 is the name of the product, this is why the proposed name. What about, b850v3-dp2 dp2 indicating the second DP output? > > Humm, b850v3 is the board name? This node should be the name of the bridge chip. >>From the cover letter: -- // -- There are two physical bridges on the video signal pipeline: a STDP4028(LVDS to DP) and a STDP2690(DP to DP++). The hardware and firmware made it complicated for this binding to comprise two device tree nodes, as the design goal is to configure both bridges based on the LVDS signal, which leave the driver powerless to control the video processing pipeline. The two bridges behaves as a single bridge, and the driver is only needed for telling the host about EDID / HPD, and for giving the host powers to ack interrupts. The video signal pipeline is as follows: Host -> LVDS|--(STDP4028)--|DP -> DP|--(STDP2690)--|DP++ -> Video output -- // --