From: Sumit Gupta <sumitg@nvidia.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>
Cc: <linux-pm@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
<linux-kernel@vger.kernel.org>, Sumit Gupta <sumitg@nvidia.com>,
Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH] cpufreq: Improve code around unlisted freq check
Date: Fri, 16 Oct 2020 16:47:34 +0530 [thread overview]
Message-ID: <75176efa-a837-004f-c9ec-c9e2370834ae@nvidia.com> (raw)
In-Reply-To: <37c3f1f76c055b305d1bba2c2001ac5b1d7a9b5f.1602565964.git.viresh.kumar@linaro.org>
On 13/10/20 10:42 AM, Viresh Kumar wrote:
> External email: Use caution opening links or attachments
>
>
> The cpufreq core checks if the frequency programmed by the bootloaders
> is not listed in the freq table and programs one from the table in such
> a case. This is done only if the driver has set the
> CPUFREQ_NEED_INITIAL_FREQ_CHECK flag.
>
> Currently we print two separate messages, with almost the same content,
> and do this with a pr_warn() which may be a bit too much as the driver
> only asked us to check this as it expected this to be the case. Lower
> down the severity of the print message by switching to pr_info() instead
> and print a single message only.
>
Reviewed-by: Sumit Gupta <sumitg@nvidia.com>
Tested-by: Sumit Gupta <sumitg@nvidia.com>
> Reported-by: Sumit Gupta <sumitg@nvidia.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/cpufreq.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 2ea245a6c0c0..99864afac272 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1461,14 +1461,13 @@ static int cpufreq_online(unsigned int cpu)
> */
> if ((cpufreq_driver->flags & CPUFREQ_NEED_INITIAL_FREQ_CHECK)
> && has_target()) {
> + unsigned int old_freq = policy->cur;
> +
> /* Are we running at unknown frequency ? */
> - ret = cpufreq_frequency_table_get_index(policy, policy->cur);
> + ret = cpufreq_frequency_table_get_index(policy, old_freq);
> if (ret == -EINVAL) {
> - /* Warn user and fix it */
> - pr_warn("%s: CPU%d: Running at unlisted freq: %u KHz\n",
> - __func__, policy->cpu, policy->cur);
> - ret = __cpufreq_driver_target(policy, policy->cur - 1,
> - CPUFREQ_RELATION_L);
> + ret = __cpufreq_driver_target(policy, old_freq - 1,
> + CPUFREQ_RELATION_L);
>
> /*
> * Reaching here after boot in a few seconds may not
> @@ -1476,8 +1475,8 @@ static int cpufreq_online(unsigned int cpu)
> * frequency for longer duration. Hence, a BUG_ON().
> */
> BUG_ON(ret);
> - pr_warn("%s: CPU%d: Unlisted initial frequency changed to: %u KHz\n",
> - __func__, policy->cpu, policy->cur);
> + pr_info("%s: CPU%d: Running at unlisted initial frequency: %u KHz, changing to: %u KHz\n",
> + __func__, policy->cpu, old_freq, policy->cur);
> }
> }
>
> --
> 2.25.0.rc1.19.g042ed3e048af
>
next prev parent reply other threads:[~2020-10-16 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 5:12 [PATCH] cpufreq: Improve code around unlisted freq check Viresh Kumar
2020-10-16 11:17 ` Sumit Gupta [this message]
2020-10-16 14:21 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75176efa-a837-004f-c9ec-c9e2370834ae@nvidia.com \
--to=sumitg@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).