linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"vigneshr@ti.com" <vigneshr@ti.com>,
	"Anson.Huang@nxp.com" <Anson.Huang@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"richard@nod.at" <richard@nod.at>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzk@kernel.org" <krzk@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"lee.jones@linaro.org" <lee.jones@linaro.org>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"han.xu@nxp.com" <han.xu@nxp.com>
Subject: Re: [PATCH v2 11/19] arm64: dts: imx8mn-ddr4-evk: Align regulator names with schema
Date: Mon, 31 Aug 2020 05:27:26 +0000	[thread overview]
Message-ID: <751b3933df6efde5ca9ad4148ddef8588459cd21.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20200828164750.10377-12-krzk@kernel.org>


On Fri, 2020-08-28 at 18:47 +0200, Krzysztof Kozlowski wrote:
> Device tree schema expects regulator names to be lowercase.  Changing
> to
> lowercase has multiple effects:
> 1. LDO6 supply is now properly configured, because regulator driver
>    looks for supplies by lowercase name,
> 2. User-visible names via sysfs or debugfs are now lowercase,
> 2. dtbs_check warnings are fixed:
> 
>     pmic@4b: regulators:LDO1:regulator-name:0: 'LDO1' does not match
> '^ldo[1-6]$'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

FWIW:
Acked-By: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

> ---
>  .../boot/dts/freescale/imx8mn-ddr4-evk.dts    | 22 +++++++++------
> ----
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> index 3ac8f9d3c372..8f7155716c84 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> @@ -60,7 +60,7 @@
>  
>  		regulators {
>  			buck1_reg: BUCK1 {
> -				regulator-name = "BUCK1";
> +				regulator-name = "buck1";
>  				regulator-min-microvolt = <700000>;
>  				regulator-max-microvolt = <1300000>;
>  				regulator-boot-on;
> @@ -69,7 +69,7 @@
>  			};
>  
>  			buck2_reg: BUCK2 {
> -				regulator-name = "BUCK2";
> +				regulator-name = "buck2";
>  				regulator-min-microvolt = <700000>;
>  				regulator-max-microvolt = <1300000>;
>  				regulator-boot-on;
> @@ -79,14 +79,14 @@
>  
>  			buck3_reg: BUCK3 {
>  				// BUCK5 in datasheet
> -				regulator-name = "BUCK3";
> +				regulator-name = "buck3";
>  				regulator-min-microvolt = <700000>;
>  				regulator-max-microvolt = <1350000>;
>  			};
>  
>  			buck4_reg: BUCK4 {
>  				// BUCK6 in datasheet
> -				regulator-name = "BUCK4";
> +				regulator-name = "buck4";
>  				regulator-min-microvolt = <3000000>;
>  				regulator-max-microvolt = <3300000>;
>  				regulator-boot-on;
> @@ -95,7 +95,7 @@
>  
>  			buck5_reg: BUCK5 {
>  				// BUCK7 in datasheet
> -				regulator-name = "BUCK5";
> +				regulator-name = "buck5";
>  				regulator-min-microvolt = <1605000>;
>  				regulator-max-microvolt = <1995000>;
>  				regulator-boot-on;
> @@ -104,7 +104,7 @@
>  
>  			buck6_reg: BUCK6 {
>  				// BUCK8 in datasheet
> -				regulator-name = "BUCK6";
> +				regulator-name = "buck6";
>  				regulator-min-microvolt = <800000>;
>  				regulator-max-microvolt = <1400000>;
>  				regulator-boot-on;
> @@ -112,7 +112,7 @@
>  			};
>  
>  			ldo1_reg: LDO1 {
> -				regulator-name = "LDO1";
> +				regulator-name = "ldo1";
>  				regulator-min-microvolt = <1600000>;
>  				regulator-max-microvolt = <3300000>;
>  				regulator-boot-on;
> @@ -120,7 +120,7 @@
>  			};
>  
>  			ldo2_reg: LDO2 {
> -				regulator-name = "LDO2";
> +				regulator-name = "ldo2";
>  				regulator-min-microvolt = <800000>;
>  				regulator-max-microvolt = <900000>;
>  				regulator-boot-on;
> @@ -128,7 +128,7 @@
>  			};
>  
>  			ldo3_reg: LDO3 {
> -				regulator-name = "LDO3";
> +				regulator-name = "ldo3";
>  				regulator-min-microvolt = <1800000>;
>  				regulator-max-microvolt = <3300000>;
>  				regulator-boot-on;
> @@ -136,7 +136,7 @@
>  			};
>  
>  			ldo4_reg: LDO4 {
> -				regulator-name = "LDO4";
> +				regulator-name = "ldo4";
>  				regulator-min-microvolt = <900000>;
>  				regulator-max-microvolt = <1800000>;
>  				regulator-boot-on;
> @@ -144,7 +144,7 @@
>  			};
>  
>  			ldo6_reg: LDO6 {
> -				regulator-name = "LDO6";
> +				regulator-name = "ldo6";
>  				regulator-min-microvolt = <900000>;
>  				regulator-max-microvolt = <1800000>;
>  				regulator-boot-on;


  reply	other threads:[~2020-08-31  5:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28 16:47 [PATCH v2 00/19] arm64: dts: imx8: Align pins and regulators with dtschema Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 01/19] dt-bindings: mfd: rohm,bd71847-pmic: Correct clock properties requirements Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 02/19] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 03/19] arm64: dts: imx8mm-beacon-kit: Add missing build through Makefile Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 04/19] arm64: dts: imx8mm-beacon-som: Align regulator names with schema Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 05/19] arm64: dts: imx8mm-beacon-som: Fix atmel,24c64 EEPROM compatible Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 06/19] arm64: dts: imx8mm-beacon: Align pin configuration group names with schema Krzysztof Kozlowski
2020-09-05  6:11   ` Shawn Guo
2020-08-28 16:47 ` [PATCH v2 07/19] arm64: dts: imx8mm-evk: Align regulator " Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 08/19] arm64: dts: imx8mm-evk: Add 32.768 kHz clock to PMIC Krzysztof Kozlowski
2020-08-31  5:30   ` Vaittinen, Matti
2020-09-05  6:11   ` Shawn Guo
2020-08-28 16:47 ` [PATCH v2 09/19] arm64: dts: imx8mm-evk: Align pin configuration group names with schema Krzysztof Kozlowski
2020-09-05  6:13   ` Shawn Guo
2020-08-28 16:47 ` [PATCH v2 10/19] arm64: dts: imx8mm-ddr4-evk: " Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 11/19] arm64: dts: imx8mn-ddr4-evk: Align regulator " Krzysztof Kozlowski
2020-08-31  5:27   ` Vaittinen, Matti [this message]
2020-08-28 16:47 ` [PATCH v2 12/19] arm64: dts: imx8mn-evk: Align pin configuration group " Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 13/19] arm64: dts: imx8mq-evk: " Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 14/19] arm64: dts: imx8mq-librem5-devkit: " Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 15/19] arm64: dts: imx8mq-phanbell: " Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 16/19] arm64: dts: imx8mq-pico-pi: " Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 17/19] arm64: dts: imx8mq-sr-som: " Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 18/19] arm64: dts: imx8mq-hummingboard-pulse: " Krzysztof Kozlowski
2020-08-28 16:47 ` [PATCH v2 19/19] arm64: dts: imx8qxp-colibri: " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=751b3933df6efde5ca9ad4148ddef8588459cd21.camel@fi.rohmeurope.com \
    --to=matti.vaittinen@fi.rohmeurope.com \
    --cc=Anson.Huang@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=han.xu@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).