From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: "anish kumar" <anish198519851985@gmail.com>, 최찬우 <cw00.choi@samsung.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] [2/2] extcon: optimising the check_mutually_exclusive function
Date: Fri, 31 Aug 2012 07:59:18 +0000 (GMT) [thread overview]
Message-ID: <7520099.93351346399957499.JavaMail.weblogic@epml19> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1489 bytes --]
> From: anish kumar <anish198519851985@gmail.com>
>
> Rather than re-inventing the wheel we can use the hamming function
> to calculate the number of bits set to check for violation of
> exclusivity.
>
> Signed-off-by: anish kumar <anish198519851985@gmail.com>
Ah.. we've got such a convinient one. Thanks.
Singed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> ---
> drivers/extcon/extcon-class.c | 14 +++++---------
> 1 files changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c
> index e09a6c3..06df95a 100644
> --- a/drivers/extcon/extcon-class.c
> +++ b/drivers/extcon/extcon-class.c
> @@ -89,17 +89,13 @@ static int check_mutually_exclusive(struct extcon_dev *edev, u32 new_state)
> return 0;
>
> for (i = 0; edev->mutually_exclusive[i]; i++) {
> - int count = 0, j;
> + int weight;
> u32 correspondants = new_state & edev->mutually_exclusive[i];
> - u32 exp = 1;
> -
> - for (j = 0; j < 32; j++) {
> - if (exp & correspondants)
> - count++;
> - if (count > 1)
> - return i + 1;
> - exp <<= 1;
> - }
> +
> + /* calculate the total number of bits set */
> + weight = hweight32(correspondants);
> + if (weight > 1)
> + return i + 1;
> }
>
> return 0;
> --
> 1.7.1
>
>
>
>
>
>
>
>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next reply other threads:[~2012-08-31 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 7:59 MyungJoo Ham [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-29 19:05 [PATCH 1/2] [1/2]extcon: standard cable names definition and declaration changed anish kumar
2012-08-29 19:05 ` [PATCH 2/2] [2/2] extcon: optimising the check_mutually_exclusive function anish kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7520099.93351346399957499.JavaMail.weblogic@epml19 \
--to=myungjoo.ham@samsung.com \
--cc=anish198519851985@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).