From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S969912AbdAEAO6 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Jan 2017 19:14:58 -0500
Received: from mga01.intel.com ([192.55.52.88]:38964 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S965157AbdAEAOy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Jan 2017 19:14:54 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,318,1477983600"; 
   d="scan'208";a="919034087"
Subject: Re: [RFC PATCH v3] sparc64: Add support for Application Data
 Integrity (ADI)
To: Rob Gardner <rob.gardner@oracle.com>,
        Khalid Aziz <khalid.aziz@oracle.com>, davem@davemloft.net,
        corbet@lwn.net, arnd@arndb.de, akpm@linux-foundation.org
References: <1483569999-13543-1-git-send-email-khalid.aziz@oracle.com>
 <6fcaab9f-40fb-fdfb-2c7e-bf21a862ab7c@linux.intel.com>
 <ae0b7d0b-54fa-fa93-3b50-d14ace1b16f5@oracle.com>
 <d234fb8b-965f-d966-46fe-965478fdf7cb@linux.intel.com>
 <8612e7db-97c5-f757-0aae-24c3acedbc29@oracle.com>
 <2c0502d0-20ef-44ac-db5b-7f651a70b978@linux.intel.com>
 <ba9c4de2-cec1-1c88-82c9-24a524eb7948@oracle.com>
 <db31d324-a1ae-7450-0e54-ad98da205773@linux.intel.com>
 <5a0270ea-b29a-0751-a27f-2412a8588561@oracle.com>
Cc: hpa@zytor.com, viro@zeniv.linux.org.uk, nitin.m.gupta@oracle.com,
        chris.hyser@oracle.com, tushar.n.dave@oracle.com,
        sowmini.varadhan@oracle.com, mike.kravetz@oracle.com,
        adam.buchbinder@gmail.com, minchan@kernel.org, hughd@google.com,
        kirill.shutemov@linux.intel.com, keescook@chromium.org,
        allen.pais@oracle.com, aryabinin@virtuozzo.com, atish.patra@oracle.com,
        joe@perches.com, pmladek@suse.com, jslaby@suse.cz,
        cmetcalf@mellanox.com, paul.gortmaker@windriver.com, mhocko@suse.com,
        jmarchan@redhat.com, lstoakes@gmail.com, 0x7f454c46@gmail.com,
        vbabka@suse.cz, tglx@linutronix.de, mingo@redhat.com,
        dan.j.williams@intel.com, iamjoonsoo.kim@lge.com,
        mgorman@techsingularity.net, vdavydov.dev@gmail.com,
        hannes@cmpxchg.org, namit@vmware.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
        linux-arch@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org,
        Khalid Aziz <khalid@gonehiking.org>
From: Dave Hansen <dave.hansen@linux.intel.com>
Message-ID: <7532a1d6-6562-b10b-dacd-931cb2a9e536@linux.intel.com>
Date: Wed, 4 Jan 2017 16:14:53 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <5a0270ea-b29a-0751-a27f-2412a8588561@oracle.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/04/2017 04:05 PM, Rob Gardner wrote:
>> What if two different small pages have different tags and khugepaged
>> comes along and tries to collapse them?  Will the page be split if a
>> user attempts to set two different tags inside two different small-page
>> portions of a single THP?
> 
> The MCD tags operate at a resolution of cache lines (64 bytes). Page
> sizes don't matter except that each virtual page must have a bit set in
> its TTE to allow MCD to be enabled on the page. Any page can have many
> different tags, one for each cache line.

Is an "MCD tag" the same thing as a "ADI version tag"?

The thing that confused me here is that we're taking an entire page of
"ADI version tags" and stuffing them into a swap pte (in
set_swp_pte_at()).  Do we somehow have enough space in a swap pte on
sparc to fit PAGE_SIZE/64 "ADI version tag"s in there?