From: Konstantin Komarov <email@example.com>
To: "Aurélien Aptel" <firstname.lastname@example.org>,
Subject: RE: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.
Date: Thu, 20 Aug 2020 10:20:26 +0000 [thread overview]
Message-ID: <email@example.com> (raw)
From: Aurélien Aptel <firstname.lastname@example.org>
Sent: Friday, August 14, 2020 5:09 PM
> Hi Konstantin,
> That's cool :) As Nikolay said it needs a little change to the makefiles
> to even build.
> Are you also going to publish your own mkfs.ntfs3 tool? I dont think the
> existing one would support 64k clusters.
Hi Aurélien. Thanks for your feedback. We plan to publish our mkfs.ntfs utility as the open source as well (and possibly fschk.ntfs - after mkfs).
> I would recommend to run checkpatch (I see already 87 warnings... some
> of it is noise):
> $ ./scripts/checkpatch.pl <patch>
> And sparse (I dont see much):
> $ touch fs/ntfs3/*.[ch] && make C=1
> You need a recent build of sparse to do that last one. You can pass your
> own sparse bin (make CHECK=~/prog/sparse/sparse C=1)
> This will be a good first step.
The sparse utility is running against the code, as well as checkpatch.pl. Sprase output is clean now. Checkpatch's somehow important warnings will be fixed in v2 (except maybe typedefs).
> Have you tried to run the xfstests suite against it?
xfstests are being one of our standard test suites among others. Currently we have the 'generic/339' and 'generic/013' test cases failing, working on it now. Other tests either pass or being skipped (due to missing features e.g. reflink).
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2020-08-20 10:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 12:29 [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software Konstantin Komarov
2020-08-14 13:17 ` Nikolay Borisov
2020-08-14 13:40 ` David Sterba
2020-08-20 9:26 ` Konstantin Komarov
2020-08-20 10:59 ` Konstantin Komarov
2020-08-14 14:08 ` Aurélien Aptel
2020-08-20 10:20 ` Konstantin Komarov [this message]
2020-08-14 15:30 ` Aurélien Aptel
2020-08-20 10:38 ` Konstantin Komarov
2020-08-15 19:06 ` David Sterba
2020-08-16 0:42 ` Matthew Wilcox
2020-08-20 10:48 ` Konstantin Komarov
2020-08-16 7:56 ` Pali Rohár
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).