* [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint()
@ 2020-12-04 8:43 Zhang Changzhong
2020-12-04 16:12 ` Mike Christie
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Zhang Changzhong @ 2020-12-04 8:43 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, Paolo Bonzini, Stefan Hajnoczi,
Mike Christie, Maurizio Lombardi
Cc: Zhang Changzhong, virtualization, kvm, netdev, linux-kernel
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
drivers/vhost/scsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 6ff8a5096..4ce9f00 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
if (!vhost_vq_is_setup(vq))
continue;
- if (vhost_scsi_setup_vq_cmds(vq, vq->num))
+ ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
+ if (ret)
goto destroy_vq_cmds;
}
--
2.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint()
2020-12-04 8:43 [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint() Zhang Changzhong
@ 2020-12-04 16:12 ` Mike Christie
2020-12-07 5:17 ` Jason Wang
2020-12-07 16:07 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Mike Christie @ 2020-12-04 16:12 UTC (permalink / raw)
To: Zhang Changzhong, Michael S. Tsirkin, Jason Wang, Paolo Bonzini,
Stefan Hajnoczi, Maurizio Lombardi
Cc: virtualization, kvm, netdev, linux-kernel
On 12/4/20 2:43 AM, Zhang Changzhong wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> ---
> drivers/vhost/scsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index 6ff8a5096..4ce9f00 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
> if (!vhost_vq_is_setup(vq))
> continue;
>
> - if (vhost_scsi_setup_vq_cmds(vq, vq->num))
> + ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
> + if (ret)
> goto destroy_vq_cmds;
> }
>
>
Reviewed-by: Mike Christie <michael.christie@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint()
2020-12-04 8:43 [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint() Zhang Changzhong
2020-12-04 16:12 ` Mike Christie
@ 2020-12-07 5:17 ` Jason Wang
2020-12-07 16:07 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2020-12-07 5:17 UTC (permalink / raw)
To: Zhang Changzhong, Michael S. Tsirkin, Paolo Bonzini,
Stefan Hajnoczi, Mike Christie, Maurizio Lombardi
Cc: virtualization, kvm, netdev, linux-kernel
On 2020/12/4 下午4:43, Zhang Changzhong wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> ---
> drivers/vhost/scsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index 6ff8a5096..4ce9f00 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
> if (!vhost_vq_is_setup(vq))
> continue;
>
> - if (vhost_scsi_setup_vq_cmds(vq, vq->num))
> + ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
> + if (ret)
> goto destroy_vq_cmds;
> }
>
Acked-by: Jason Wang <jasowang@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint()
2020-12-04 8:43 [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint() Zhang Changzhong
2020-12-04 16:12 ` Mike Christie
2020-12-07 5:17 ` Jason Wang
@ 2020-12-07 16:07 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2020-12-07 16:07 UTC (permalink / raw)
To: Zhang Changzhong
Cc: Michael S. Tsirkin, Jason Wang, Paolo Bonzini, Stefan Hajnoczi,
Mike Christie, Maurizio Lombardi, virtualization, kvm, netdev,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
On Fri, Dec 04, 2020 at 04:43:30PM +0800, Zhang Changzhong wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> ---
> drivers/vhost/scsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-07 16:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-04 8:43 [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint() Zhang Changzhong
2020-12-04 16:12 ` Mike Christie
2020-12-07 5:17 ` Jason Wang
2020-12-07 16:07 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).