From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752284AbdBCDYQ (ORCPT ); Thu, 2 Feb 2017 22:24:16 -0500 Received: from mail-cys01nam02on0101.outbound.protection.outlook.com ([104.47.37.101]:50498 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751931AbdBCDYO (ORCPT ); Thu, 2 Feb 2017 22:24:14 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=zi.yan@cs.rutgers.edu; From: Zi Yan To: Hillf Danton CC: Anshuman Khandual , Andrew Morton , Naoya Horiguchi , "Kirill A. Shutemov" , , Hugh Dickins , Dave Hansen , Andrea Arcangeli , Mel Gorman , Michal Hocko , Vlastimil Babka , Pavel Emelyanov , Balbir Singh , , Naoya Horiguchi Subject: Re: [PATCH v2 00/12] mm: page migration enhancement for thp Date: Thu, 2 Feb 2017 21:24:03 -0600 Message-ID: <75577D22-DDFB-4CAA-B272-B28CBC3FBE7F@cs.rutgers.edu> In-Reply-To: <004601d27dcb$509327a0$f1b976e0$@alibaba-inc.com> References: <1478561517-4317-1-git-send-email-n-horiguchi@ah.jp.nec.com> <5890EB58.3050100@cs.rutgers.edu> <004601d27dcb$509327a0$f1b976e0$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_MailMate_B5BB235C-6606-4538-B0D7-BF8540E684A2_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Mailer: MailMate (2.0BETAr6074) X-Originating-IP: [24.55.27.203] X-ClientProxiedBy: MWHPR10CA0010.namprd10.prod.outlook.com (10.172.48.20) To CY4PR14MB1654.namprd14.prod.outlook.com (10.171.166.16) X-MS-Office365-Filtering-Correlation-Id: 03aceb4a-60d3-436f-c59b-08d44be41ece X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR14MB1654; X-Microsoft-Exchange-Diagnostics: 1;CY4PR14MB1654;3:e8e58AYL1Fc97Rl0RCFdImIQlmG8tPnmcfm90tshCA78E2MjE82BghSZnfJiurI2zArdZknoNoQWpLy+wqdm010QszJSpTldfSptzLpRQhY2LVSZq6mU8vWQmxAJIlYZ4H5K/bKP4IRevjVDyqTrXeHMUKJV9GTv3MChl8lveeqlG0a76mKEfvVAOj9sJUurBVKugIO2HcGKzPuWFkD2yKYYFqTNHW3wEI5zUv+Gz9inYAIT5L6HsnEurTqijqFAVJ6M2rkFIajn94fwH+9LEw==;25:lCS1XWwBgQCBs2XQsdwVgmPMx3D2Z6cL6y0EFj3xctu1G2GgJXgNjE+4yXhbRgUo4989CImQEQm7ewgyXv8DmXSUX2iJTMHNGqxJtKG+520YTL/RKfKB19pS5tZYXJjJPYXaMyRpnyixjbBuKhwiXI28+MoUgt8SAmmKFR6tIu1gqCgnc1nbRZQznT4Me869UmVNP/ux9PLj2iF676HLAlu+sDOlvA4/nwNhiEb78t/EspLiaMeIleGmkaOssbxaALFeLVHD4FAucPuqU7+HJnlQBz/m0U8hs/RGQWZrHafhNOQ/j5ESRxlcDvkKjFslGx6NgiMXWd2Nlu1w1ZkmK4JTcFLH8JcVg8fGgDsv/pHB920P/AqkYtmMM6y7zaOdL0sLQy95lozBrxsgE0vazywhs+A0ZqDAmC42mZ9HLzwRJfdBcR5y+uL3RuqZiR+J X-Microsoft-Exchange-Diagnostics: 1;CY4PR14MB1654;31:WwjvYAW6lblbOAcUqmUxdvIIoLHqvFQIvpQSjhTlXLEDFBBJ3E2fyXC4vtYYVj5zk7gDJIiniYvq56uze8cFqor3h9gMMSxbMB9bjKOD7NxSvVfLOh4TIwlyORSFFNjgafvyReVL5ShfTfrPgjEUjx1wQ7zgS3x3nIhuCFp+gG2U7K/j8WEEbExaDUTN2oq3cVDM5ti2mwu1gH4nefhoHeneApIfjpX4zvrMPHGenlFh+1kxcfGLF21L8mVK7+TTyGuhRppidcNv1cbqLY+tTg==;20:ZeuGvFZxRw7PYG0SxZiXBiFeupT1wrFkXPIzvzfTqJx0xR7FsYnbNqQD+XaTdMK2aRpDMn3l4RY8adTyw2mAdVfWqsNTxpufEXvI1BBKX6/5hzj97JCk6IBJJrfB8srh6PYCQLg9rxo/bYzmLhB/Z3Ht4z4ScpGnsYiZ6rJHm53L9kOiJQMk33FjfmkPx2hyEj6KdfXL6cT2G9XroTQzUbcLTYSfGJ7MAbf8oIIY2a6giWemTOpFfh9bTawcZbkBgP4AqTsRB0V35+W5uT1BXmqCjxTGHLRvPeJeoDDKZif1ym9iidipx9yMszie/OVoPBGgeswNMvzeSWIG1d+7wN2T1jYQlotse6z+o//3hwfd0mHIgPo1lVb26vCgh/Abf9Nh4FM4e+DHjjAR6NVI99ohgakg9jZsRdYIOh401gt+QTQ4/TXvEJ07grfSgrCxxKu1N3HWlOXMkBE/dI6SvVQoMybYRCb71AfbMmbdwbYCDQRdQ8mm99a8VJbY029S X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123558025)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(6072148);SRVR:CY4PR14MB1654;BCL:0;PCL:0;RULEID:;SRVR:CY4PR14MB1654; X-Microsoft-Exchange-Diagnostics: 1;CY4PR14MB1654;4:MAZa4BcHYpTbBrr1k5Pjew+WvzB+IsK/xyvRV+dWOrFvtoKzmbp7RDPwQ/gcwLhnitWOoA/ny1obPElA4ThLhJN6so4wHH/Hle9CrhNpT5xAvIGkhL6PFa+GNDN4XmueJDuXqRr2QlrZoYLK3K61dDlDXjzTSyQvGB4GwpK9Q0TTFEai+bVkwGx8Vfsm6Svs2m79Y4qMApT7c3XIfvJnLxwqSHW4iT1mbUUFyFnBed+P85ruSjv9lnWbtKsLf8oLbNUzK4PBU4wJAatwZbkPt19jhRQt/q135e4VNJvcBmtP7MdGFaYi9aC1evscbpGHiREFZ+qZZBHVFieyR/pQg7klaXWEMuGSl+G09HdWgB1UfzSvVOhuzgRrlpccNEh9lM1ps/LjB7Up2+QqMbwHKXrPJKjk1Ho/lZo9cMoaZg0nVG0JxpEzYN3QprmP80HHerkj6M5Goku7/eZcuhzLKIoFm2u//t0gdUtGWitJ+1aWY0G4WKjrAdwHrTUbkAz5rmI5Qd2TU0SV5pIebbj/lYeAxbAt75FOtOQF+l7Q+L1TH7aEkT+WQ2MlVuVCDnp+nzkI/KbMTJzwhuJqieX1fxTn2Ug+Zn60dQ+k61SK+B8= X-Forefront-PRVS: 02070414A1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(39410400002)(39830400002)(39450400003)(377454003)(53754006)(189002)(24454002)(199003)(117156001)(53936002)(53546003)(21480400002)(7416002)(189998001)(105586002)(97736004)(4001150100001)(93886004)(6246003)(305945005)(92566002)(106356001)(42186005)(8676002)(101416001)(7736002)(33656002)(81156014)(81166006)(75432002)(50226002)(2906002)(68736007)(5660300001)(110136003)(6666003)(2950100002)(42882006)(4326007)(568964002)(76176999)(38730400001)(83716003)(6916009)(84326002)(50986999)(82746002)(6116002)(6306002)(25786008)(88552002)(3846002)(5890100001)(229853002)(39060400001)(6486002)(77096006)(86362001)(54906002)(90366009)(66066001)(104396002)(72826003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR14MB1654;H:[192.168.29.153];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR14MB1654;23:1a532toLkU8m+MtUnXHosCV8U62s3+nplljaQiIVr?= =?us-ascii?Q?REpTi3gMwtxZDf45CH24rspbm0lr44b2esrsib6jUaCavi7Jn8ApwlUe9A/K?= =?us-ascii?Q?uMpDKbkE3gRDhleSygJTS98BUITIHNVuXsDhnJW3upOF2rudu1BXrD04VK6h?= =?us-ascii?Q?M+PeQxnvTxJq/dg2g384zRlgRSQ8pRCkY60iotVZsor4ltNNbZijhedLZ3sD?= =?us-ascii?Q?Haw1LJj6kW6qpWMwCEugsoBJr6oTEGQYDcsDW3iD0O37xXW1RbOTzoHbd0kC?= =?us-ascii?Q?uctLItQjknHz5uuO5IA3m1HNvi1VWN6ilaclPmYsBh1puW4A8VNwHju0m46p?= =?us-ascii?Q?4mZ9E/vjM66QrlvAO5Km0PRzHm6wbDettzDxKv02xNxsbTPjFDYxGMrMMVaT?= =?us-ascii?Q?Yk24Hmk9X6Fr0bSDUDUDGikbAZQA5feRoLYcGqMy9RiN6gGtVh4O026Zxal1?= =?us-ascii?Q?gM9z6IK9nGvJKWsKOyywvnQkqQ42S+7Hf0D9oPjLQ2i8OkzGIEFQnzU8BYHs?= =?us-ascii?Q?gb5akvG3hB4zFTYuZkzl99qHp3UWxha5bXgCXCQHGpJtnXBSUyH5zs7zbttM?= =?us-ascii?Q?NFbS7ocLPUtmy6Ljk1lyTYUrEu+uihTlA8N63MVlD8IcvXJlHjNv3dEeGdRq?= =?us-ascii?Q?tGo8bxzouDIbU/YFtaqSH4H4UbAw0VC08SqQsv6xAPwEoML1dtm4Mz5VJgnx?= =?us-ascii?Q?iq/FDdZ26zwdOMTWt6rLonCGER4oMy+C/1Wyy2USX0id7PYPIrsvlWPDr54V?= =?us-ascii?Q?729/4+1fainJYkOJl1OYSRQf6rcq288WKuQGc7V2/nX5O5llv/imDQnYtKr5?= =?us-ascii?Q?20He9pOFn+PLP/zfMIjhmu4CCy5BVHsIbTmZNoWgJQZIFumyxu/NK32cE0Rc?= =?us-ascii?Q?OQklvZX5XN8fO5luir4eainx+JHBKS/qhFbNuQHKY4VW/Fj/rbY7mnGGS9tk?= =?us-ascii?Q?N0TCkzEAS15Y7J12+8y55KZfBS4YCTLVrLVeAMa3dBxYTtNnsR3odXMuRDFT?= =?us-ascii?Q?lHxiyObiYYUUsCFptL4coCPPYghc9xbiCot3dGolmI6c6GNbKXyxiGbh0ubk?= =?us-ascii?Q?OfSsT6T3HvoXP74CahEomqlyr84+1uStkZjyPFb9KExCE0Oruxh7d6HuZvqq?= =?us-ascii?Q?tTNCVyRelxsHsMf8NcWy+TQl5090VVyG38JZzNtDYbugf7oYOL83D0rgoOUv?= =?us-ascii?Q?MRYEErbTynJOnqbYPaiyqUY7/72lf4i5Fsppo/kLi7nYQ+Lo+D8QGnFgiijI?= =?us-ascii?Q?Qxb3XWcXKZzcaZ0QyjgWc16HD9ABRs19cMjuOWJsVPeK5iDoCU3x9qskLzXS?= =?us-ascii?Q?dDEoPUJ2bgl3fIz4yCBmp07zZghPhlUjXkhYN4nDERsuWnq2Buowix0oEY4m?= =?us-ascii?Q?ESNVCGBbas4dvd8yHis8yvIYXjw9J/ZSB+BryA8vChfLeByEg2jS9PTp9fhB?= =?us-ascii?Q?mh6MEclU8pviJsGtA9d/OKby27E0EVL1h1Og8zFWNAJqYH3vHuG6tMgpzm+V?= =?us-ascii?Q?kXX55omn1Zs84rhsbbE4+jdMaabGkWh/ocmybIa1apBkT80JrM08e7dLMRci?= =?us-ascii?Q?H9GCHoGJvmmhk0pWL8Zqn7ERCDAxlDar0FC/EDxttPWTB9WgLEeMnq3KkmZ?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR14MB1654;6:hAydB9ov8OwAZFiJJ9n62Qr0wVMyPIc9p2+LGvQt1lS8qpc2qTghhyqTtMRUVbm7yzx7EnKbCAI2gszHpLcpSZz+DERE9uKm3E9o0ulESb8eMwfY3+O++tNxvHR2317FfUqDR7uN0ByWgIb3gX/1JOu9fMY3d4dRjKVDtAR8BenzSYTwiiUL+6uZEawrco/y1fwplaLgEDDYJXen2wdSJ0ys+UcTCibKlaJ5ERieWUgXm1lHesWe2FnA6uI/x7FsBc0QOSQzgiOGUnrQHkAHkg9dxDxlDq7CdSqCVo7F2WRqGkJlqeLLiD6Ukkl1kCnJCtW1tZ0VzPpgsoEdFcwhsMBLywtaB7G1TTTLk8MPQM/RIPo192eJjiLIEaaGzM6PQ2XeEvMI0mn3p78Vq6KM6A==;5:QKA/y/y0Ki03OmyDnDmChteWkW7uEorj/YMIdmdEIPz3HJNm1/CevlMAwZIt3fZDKVp2bJOejuERIUS4gEd7W7r9amLyvUTUs8tazgd7f11Zs3e9QhYlbdL8VqK0VT/1gMUj9kXpyDIaUVmlNzboXw==;24:AYwNNmkTMWCGEg2WPPWZDAq6ZuZJF9Vik3taBaXCU82JMEh+PdMxovb1eVuJuhuRvgNfdSxDXgz8LT9E0FLGfB3SR+0yMku1COHCbMTveJM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR14MB1654;7:x0CVFdoeFzbRrqu+O1pqekk7jZ/x62noVo7v44Zkxdr/wFdwWEnMHPD8Ih4zcdHaV9RRiCCFoVR4YGkHBxCYhsSf+vEanNa2vxtKVcr01JRsR8Xjz9M/vWWIcLAUOughJzisU4B9G0lx2vKmQW/ItEqSGDZZ7MkXK3/0BclBaoJiGDexUVsixl41uvv8wCGIPILvAl6QuQbmo6ALpZdKN6UqxSIkLtFOY7VyDZ4f0TFLQWdVijRL12fv0CDELPj4b6q40ogn7bLFKUTmEwdXMSCahLWodYUpXV0/mxL4CdOHOmpGG1krkzOoZUdSREWskTWzajYdff84wYa5cLr/fyLKWt+V0EzqDi5AE/sdNR3w/2Cp8RU9QMKUycDFZYggYLO7MFt5Bc0ygUX8HMNTXfTo5uQg0RmFyxcVMCzO77+6DHWZzOUfr34ROG6IC29VBuh1q4Cb2TRO/9VQfgT7pPd95h+TeSLsNvtxYRU04wgdVxe/xjhJgXEO0+fy8H8VpUnNay9SWDgIOt5aodpFsQ== X-OriginatorOrg: cs.rutgers.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2017 03:24:08.7509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR14MB1654 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=_MailMate_B5BB235C-6606-4538-B0D7-BF8540E684A2_= Content-Type: text/plain; markup=markdown On 2 Feb 2017, at 21:12, Hillf Danton wrote: > On February 01, 2017 3:54 AM Zi Yan wrote: >> >> I am also doing some tests on THP migration and discover that there are >> some corner cases not handled in this patchset. >> >> For example, in handle_mm_fault, without taking pmd_lock, the kernel may >> see pmd_none(*pmd) during THP migrations, which leads to >> handle_pte_fault or even deeper in the code path. At that moment, >> pmd_trans_unstable() will treat a pmd_migration_entry as pmd_bad and >> clear it. This leads to application crashing and page table leaks, since >> a deposited PTE page is not released when the application crashes. >> >> Even after I add is_pmd_migration_entry() into pmd_trans_unstable(), I >> still see application data corruptions. >> >> I hope someone can shed some light on how to debug this. Should I also >> look into pmd_trans_huge() call sites where pmd_migration_entry should >> be handled differently? >> > Hm ... seems it helps more if you post your current works as RFC on > top of the mm tree, and the relevant tests as well. > Thanks for replying. I find that data corruption is caused by that set_pmd_migration_entry() did not flush TLB while changing pmd entries. I fix it by using pmdp_huge_clear_flush() instead of pmdp_huge_get_and_clear(). The racy pmd check in zap_pmd_range() also causes pmd_bad() problem. I am going to rebase Naoya's patches and send it again for comments. > Hillf >> >> Anshuman Khandual wrote: >>> On 11/08/2016 05:01 AM, Naoya Horiguchi wrote: >>>> Hi everyone, >>>> >>>> I've updated thp migration patches for v4.9-rc2-mmotm-2016-10-27-18-27 >>>> with feedbacks for ver.1. >>> >>> Hello Noaya, >>> >>> I have been working with Zi Yan on the parallel huge page migration series >>> (https://lkml.org/lkml/2016/11/22/457) and planning to post them on top of >>> this THP migration enhancement series. Hence we were wondering if you have >>> plans to post a new version of this series in near future ? >>> >>> Regards >>> Anshuman >>> >> >> -- >> Best Regards, >> Yan Zi -- Best Regards Yan Zi --=_MailMate_B5BB235C-6606-4538-B0D7-BF8540E684A2_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJYk/fUAAoJEEGLLxGcTqbMcosH/3YBjWIpWurwYGqLgjAbnVot 3wOl5KXkVKm8fJKrjlqgGOk87fP5OvsQDSSzZb6B9Ejv3BkymySOqIgfZEH4PH6N nVw+lKYHic3JnAMukEQbnXi4l37gZhhm1s9NWOqSg5xIzKiujkorgQ//H2HeH5h7 OlIdkJi83c/e/Vde9NzVBHyqQhP12IH/FeCqzA3IUc/d3rU6x1io36K965NTmgS6 eUyG+Q1zDOTFiCXFb0XfIDIsYmw0Kp2ekDSKajwgC5EP6wGTgaV9hvyEjmYoHF8z zKW8NYsgAu6YtbxgT8wSi2CqiBCMcxE1/iOSZpwbKDMgqTbEGBRWTlH1NXj73tA= =1oHD -----END PGP SIGNATURE----- --=_MailMate_B5BB235C-6606-4538-B0D7-BF8540E684A2_=--