From: Paolo Bonzini <pbonzini@redhat.com>
To: "Mi, Dapeng1" <dapeng1.mi@intel.com>, "Christopherson,,
Sean" <seanjc@google.com>
Cc: "rafael@kernel.org" <rafael@kernel.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>
Subject: Re: [PATCH] KVM: x86: use TPAUSE to replace PAUSE in halt polling
Date: Fri, 26 Aug 2022 12:14:29 +0200 [thread overview]
Message-ID: <7558c548-7866-9176-34a2-056f4a72a483@redhat.com> (raw)
In-Reply-To: <PH0PR11MB4824201DABEFF588B4E0FE34CD729@PH0PR11MB4824.namprd11.prod.outlook.com>
On 8/25/22 13:31, Mi, Dapeng1 wrote:
>> I say "if", because I think this needs to come with performance numbers to show
>> the impact on guest latency so that KVM and its users can make an informed
>> decision.
>> And if it's unlikely that anyone will ever want to enable TPAUSE for halt polling,
>> then it's not worth the extra complexity in KVM.
> I ever run two scheduling related benchmarks, hackbench and schbench, I didn't see there are obvious performance impact.
>
> Here are the hackbench and schbench data on Intel ADL platform.
Can you confirm (using debugfs for example) that halt polling is used
while hackbench is running, and not used while it is not running?
In particular, I think you need to run the server and client on
different VMs, for example using netperf's UDP_RR test. With hackbench
the ping-pong is simply between two tasks on the same CPU, and the
hypervisor is not exercised at all.
Paolo
next prev parent reply other threads:[~2022-08-26 10:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 9:11 [PATCH] KVM: x86: use TPAUSE to replace PAUSE in halt polling Dapeng Mi
2022-08-24 14:08 ` David Laight
2022-08-25 11:08 ` Mi, Dapeng1
2022-08-24 15:26 ` Sean Christopherson
2022-08-24 17:19 ` Paolo Bonzini
2022-08-25 12:16 ` Mi, Dapeng1
2022-08-25 11:31 ` Mi, Dapeng1
2022-08-26 10:14 ` Paolo Bonzini [this message]
2022-08-30 5:56 ` Mi, Dapeng1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7558c548-7866-9176-34a2-056f4a72a483@redhat.com \
--to=pbonzini@redhat.com \
--cc=daniel.lezcano@linaro.org \
--cc=dapeng1.mi@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=seanjc@google.com \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).