From: Omar Sandoval <osandov@osandov.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Christoph Hellwig <hch@infradead.org>,
David Sterba <dsterba@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Omar Sandoval <osandov@osandov.com>
Subject: [PATCH 1/8] nfs: follow direct I/O write locking convention
Date: Sun, 14 Dec 2014 21:26:55 -0800 [thread overview]
Message-ID: <7561c096c7de603ac39fcfcff7bd2ec80589cae1.1418618044.git.osandov@osandov.com> (raw)
In-Reply-To: <cover.1418618044.git.osandov@osandov.com>
In-Reply-To: <cover.1418618044.git.osandov@osandov.com>
The generic callers of direct_IO lock i_mutex before doing a write. NFS
doesn't use the generic write code, so it doesn't follow this
convention. This is now a problem because the interface introduced for
swap-over-NFS calls direct_IO for a write without holding i_mutex, but
other implementations of direct_IO will expect to have it locked.
Signed-off-by: Omar Sandoval <osandov@osandov.com>
---
fs/nfs/direct.c | 12 +++++-------
fs/nfs/file.c | 8 ++++++--
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
index 10bf072..9402b96 100644
--- a/fs/nfs/direct.c
+++ b/fs/nfs/direct.c
@@ -906,17 +906,15 @@ ssize_t nfs_file_direct_write(struct kiocb *iocb, struct iov_iter *iter,
if (!count)
goto out;
- mutex_lock(&inode->i_mutex);
-
result = nfs_sync_mapping(mapping);
if (result)
- goto out_unlock;
+ goto out;
if (mapping->nrpages) {
result = invalidate_inode_pages2_range(mapping,
pos >> PAGE_CACHE_SHIFT, end);
if (result)
- goto out_unlock;
+ goto out;
}
task_io_account_write(count);
@@ -924,7 +922,7 @@ ssize_t nfs_file_direct_write(struct kiocb *iocb, struct iov_iter *iter,
result = -ENOMEM;
dreq = nfs_direct_req_alloc();
if (!dreq)
- goto out_unlock;
+ goto out;
dreq->inode = inode;
dreq->bytes_left = count;
@@ -960,12 +958,12 @@ ssize_t nfs_file_direct_write(struct kiocb *iocb, struct iov_iter *iter,
}
}
nfs_direct_req_release(dreq);
+
+ mutex_lock(&inode->i_mutex);
return result;
out_release:
nfs_direct_req_release(dreq);
-out_unlock:
- mutex_unlock(&inode->i_mutex);
out:
return result;
}
diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 2ab6f00..8b80276 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -675,8 +675,12 @@ ssize_t nfs_file_write(struct kiocb *iocb, struct iov_iter *from)
if (result)
return result;
- if (file->f_flags & O_DIRECT)
- return nfs_file_direct_write(iocb, from, pos);
+ if (file->f_flags & O_DIRECT) {
+ mutex_lock(&inode->i_mutex);
+ result = nfs_file_direct_write(iocb, from, pos);
+ mutex_unlock(&inode->i_mutex);
+ return result;
+ }
dprintk("NFS: write(%pD2, %zu@%Ld)\n",
file, count, (long long) pos);
--
2.1.3
next prev parent reply other threads:[~2014-12-15 5:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 5:26 [PATCH 0/8] clean up and generalize swap-over-NFS Omar Sandoval
2014-12-15 5:26 ` Omar Sandoval [this message]
2014-12-15 12:49 ` [PATCH 1/8] nfs: follow direct I/O write locking convention Trond Myklebust
2014-12-15 15:42 ` Omar Sandoval
2014-12-15 5:26 ` [PATCH 2/8] swap: lock i_mutex for swap_writepage direct_IO Omar Sandoval
2014-12-15 16:27 ` Jan Kara
2014-12-15 16:56 ` Christoph Hellwig
2014-12-15 22:11 ` Omar Sandoval
2014-12-16 8:35 ` Christoph Hellwig
2014-12-16 8:56 ` Omar Sandoval
2014-12-17 8:06 ` Christoph Hellwig
2014-12-17 8:20 ` Al Viro
2014-12-17 8:24 ` Christoph Hellwig
2014-12-17 14:58 ` Omar Sandoval
2014-12-17 18:52 ` Christoph Hellwig
2014-12-17 22:03 ` Al Viro
2014-12-19 6:24 ` Omar Sandoval
2014-12-19 6:28 ` Al Viro
2014-12-20 6:51 ` Al Viro
2014-12-22 7:26 ` Omar Sandoval
2014-12-23 9:37 ` Christoph Hellwig
2014-12-15 5:26 ` [PATCH 3/8] swap: don't add ITER_BVEC flag to direct_IO rw Omar Sandoval
2014-12-15 6:16 ` Al Viro
2014-12-15 15:57 ` Omar Sandoval
2014-12-15 5:26 ` [PATCH 4/8] iov_iter: add iov_iter_bvec and convert callers Omar Sandoval
2014-12-15 5:26 ` [PATCH 5/8] direct-io: don't dirty ITER_BVEC pages on read Omar Sandoval
2014-12-15 5:27 ` [PATCH 6/8] nfs: don't dirty ITER_BVEC pages read through direct I/O Omar Sandoval
2014-12-15 6:17 ` Al Viro
2014-12-15 5:27 ` [PATCH 7/8] swap: use direct I/O for SWP_FILE swap_readpage Omar Sandoval
2014-12-15 5:27 ` [PATCH 8/8] vfs: update swap_{,de}activate documentation Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7561c096c7de603ac39fcfcff7bd2ec80589cae1.1418618044.git.osandov@osandov.com \
--to=osandov@osandov.com \
--cc=akpm@linux-foundation.org \
--cc=dsterba@suse.cz \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).