From: Aakash Hemadri <aakashhemadri123@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v4 1/5] staging: r8188eu: restricted __be16 degrades to int
Date: Mon, 23 Aug 2021 22:30:26 +0530 [thread overview]
Message-ID: <7572c80d90b499df7e9feb4781c07967fa31bf88.1629563318.git.aakashhemadri123@gmail.com> (raw)
In-Reply-To: <cover.1629563318.git.aakashhemadri123@gmail.com>
Fix sparse warning:
> rtw_br_ext.c:73:23: warning: restricted __be16 degrades to integer
Here tag->tag_len is be16, use be16_to_cpu()
Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
---
Prefer using be16_to_cpu() over ntohs()
drivers/staging/r8188eu/core/rtw_br_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
index ee52f28a1e56..f6d1f6029ec3 100644
--- a/drivers/staging/r8188eu/core/rtw_br_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
@@ -70,7 +70,7 @@ static int __nat25_add_pppoe_tag(struct sk_buff *skb, struct pppoe_tag *tag)
struct pppoe_hdr *ph = (struct pppoe_hdr *)(skb->data + ETH_HLEN);
int data_len;
- data_len = tag->tag_len + TAG_HDR_LEN;
+ data_len = be16_to_cpu(tag->tag_len) + TAG_HDR_LEN;
if (skb_tailroom(skb) < data_len) {
_DEBUG_ERR("skb_tailroom() failed in add SID tag!\n");
return -1;
--
2.32.0
next prev parent reply other threads:[~2021-08-23 17:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 17:00 [PATCH v4 0/5] staging: r8188eu: fix sparse warnings Aakash Hemadri
2021-08-23 17:00 ` Aakash Hemadri [this message]
2021-08-23 17:00 ` [PATCH v4 2/5] staging: r8188eu: cast to restricted __be32 Aakash Hemadri
2021-08-23 17:00 ` [PATCH v4 3/5] staging: r8188eu: incorrect type in csum_ipv6_magic Aakash Hemadri
2021-08-25 9:23 ` David Laight
2021-08-28 8:45 ` Aakash Hemadri
2021-08-23 17:00 ` [PATCH v4 4/5] staging: r8188eu: restricted __be16 degrades to int Aakash Hemadri
2021-08-23 17:00 ` [PATCH v4 5/5] staging: r8188eu: incorrect type in assignment Aakash Hemadri
2021-08-28 8:50 ` [PATCH v4 0/5] staging: r8188eu: fix sparse warnings Aakash Hemadri
2021-08-28 9:44 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7572c80d90b499df7e9feb4781c07967fa31bf88.1629563318.git.aakashhemadri123@gmail.com \
--to=aakashhemadri123@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).