From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758183AbcK2RY0 (ORCPT ); Tue, 29 Nov 2016 12:24:26 -0500 Received: from foss.arm.com ([217.140.101.70]:53056 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933311AbcK2RWs (ORCPT ); Tue, 29 Nov 2016 12:22:48 -0500 Subject: Re: [PATCH 15/22] arm64/cpuinfo: Make hotplug notifier symmetric To: Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org References: <20161126231350.10321-1-bigeasy@linutronix.de> <20161126231350.10321-16-bigeasy@linutronix.de> Cc: rt@linutronix.de, tglx@linutronix.de, Anna-Maria Gleixner , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org From: Suzuki K Poulose Message-ID: <758dd144-6634-a8ad-2af0-abe7478dd94f@arm.com> Date: Tue, 29 Nov 2016 17:22:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161126231350.10321-16-bigeasy@linutronix.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/11/16 23:13, Sebastian Andrzej Siewior wrote: > From: Anna-Maria Gleixner > > There is no requirement to keep the sysfs files around until the CPU is > completely dead. Remove them during the DOWN_PREPARE notification. This is > a preparatory patch for converting to the hotplug state machine. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Anna-Maria Gleixner > Signed-off-by: Sebastian Andrzej Siewior > --- > arch/arm64/kernel/cpuinfo.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c > index b3d5b3e8fbcb..19aad7041e14 100644 > --- a/arch/arm64/kernel/cpuinfo.c > +++ b/arch/arm64/kernel/cpuinfo.c > @@ -272,9 +272,10 @@ static int cpuid_callback(struct notifier_block *nb, > > switch (action & ~CPU_TASKS_FROZEN) { > case CPU_ONLINE: > + case CPU_DOWN_FAILED: > rc = cpuid_add_regs(cpu); > break; > - case CPU_DEAD: > + case CPU_DOWN_PREPARE: > rc = cpuid_remove_regs(cpu); > break; > } Looks reasonable to me: Reviewed-by : Suzuki K Poulose