From: CK Hu <ck.hu@mediatek.com>
To: Bo-Chen Chen <rex-bc.chen@mediatek.com>,
<chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
<daniel@ffwll.ch>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <matthias.bgg@gmail.com>, <deller@gmx.de>,
<airlied@linux.ie>
Cc: <msp@baylibre.com>, <granquet@baylibre.com>,
<jitao.shi@mediatek.com>, <wenst@chromium.org>,
<angelogioacchino.delregno@collabora.com>,
<liangxu.xu@mediatek.com>, <dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-fbdev@vger.kernel.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v16 3/8] drm/mediatek: Add MT8195 Embedded DisplayPort driver
Date: Mon, 8 Aug 2022 12:48:01 +0800 [thread overview]
Message-ID: <759311a0e40401c3c0f230e700b00878daf81a87.camel@mediatek.com> (raw)
In-Reply-To: <20220805101459.3386-4-rex-bc.chen@mediatek.com>
Hi. Bo-Chen:
On Fri, 2022-08-05 at 18:14 +0800, Bo-Chen Chen wrote:
> From: Markus Schneider-Pargmann <msp@baylibre.com>
>
> This patch adds a embedded displayport driver for the MediaTek mt8195
> SoC.
>
> It supports the MT8195, the embedded DisplayPort units. It offers
> DisplayPort 1.4 with up to 4 lanes.
>
> The driver creates a child device for the phy. The child device will
> never exist without the parent being active. As they are sharing a
> register range, the parent passes a regmap pointer to the child so
> that
> both can work with the same register range. The phy driver sets
> device
> data that is read by the parent to get the phy device that can be
> used
> to control the phy properties.
>
> This driver is based on an initial version by
> Jitao shi <jitao.shi@mediatek.com>
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> Tested-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> ---
[snip]
> +
> +static int mtk_dp_parse_capabilities(struct mtk_dp *mtk_dp)
> +{
> + u8 val;
> + ssize_t ret;
> + struct mtk_dp_train_info *train_info = &mtk_dp->train_info;
> +
> + drm_dp_dpcd_writeb(&mtk_dp->aux, DP_SET_POWER,
> DP_SET_POWER_D0);
> + usleep_range(2000, 5000);
> +
> + drm_dp_read_dpcd_caps(&mtk_dp->aux, mtk_dp->rx_cap);
> +
> + train_info->link_rate = min_t(int, mtk_dp->max_linkrate,
> + drm_dp_max_link_rate(mtk_dp-
> >rx_cap));
> + train_info->lane_count = min_t(int, mtk_dp->max_lanes,
> + drm_dp_max_lane_count(mtk_dp-
> >rx_cap));
> +
> + train_info->tps3 = drm_dp_tps3_supported(mtk_dp->rx_cap);
> + train_info->tps4 = drm_dp_tps4_supported(mtk_dp->rx_cap);
You could drop tps3, tps4 and add channel_eq_pattern like this:
if (drm_dp_tps4_supported(mtk_dp->rx_cap))
train_info->channel_eq_pattern = DP_TRAINING_PATTERN_4;
else if (drm_dp_tps4_supported(mtk_dp->rx_cap))
train_info->channel_eq_pattern = DP_TRAINING_PATTERN_3;
else
train_info->channel_eq_pattern = DP_TRAINING_PATTERN_2;
Regards,
CK
> +
> + train_info->sink_ssc = drm_dp_max_downspread(mtk_dp->rx_cap);
> +
> + ret = drm_dp_dpcd_readb(&mtk_dp->aux, DP_MSTM_CAP, &val);
> + if (ret < 1) {
> + drm_err(mtk_dp->drm_dev, "Read mstm cap failed\n");
> + return ret == 0 ? -EIO : ret;
> + }
> +
> + if (val & DP_MST_CAP) {
> + /* Clear DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0 */
> + ret = drm_dp_dpcd_readb(&mtk_dp->aux,
> + DP_DEVICE_SERVICE_IRQ_VECTOR_ES
> I0,
> + &val);
> + if (ret < 1) {
> + drm_err(mtk_dp->drm_dev, "Read irq vector
> failed\n");
> + return ret == 0 ? -EIO : ret;
> + }
> +
> + if (val)
> + drm_dp_dpcd_writeb(&mtk_dp->aux,
> + DP_DEVICE_SERVICE_IRQ_VECTOR
> _ESI0,
> + val);
> + }
> +
> + return 0;
> +}
> +
next prev parent reply other threads:[~2022-08-08 4:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 10:14 [PATCH v16 0/8] drm/mediatek: Add MT8195 DisplayPort driver Bo-Chen Chen
2022-08-05 10:14 ` [PATCH v16 1/8] dt-bindings: mediatek,dp: Add Display Port binding Bo-Chen Chen
2022-08-09 19:46 ` Rob Herring
2022-08-05 10:14 ` [PATCH v16 2/8] video/hdmi: Add audio_infoframe packing for DP Bo-Chen Chen
2022-08-05 10:14 ` [PATCH v16 3/8] drm/mediatek: Add MT8195 Embedded DisplayPort driver Bo-Chen Chen
2022-08-08 4:03 ` CK Hu
2022-08-08 4:48 ` CK Hu [this message]
2022-08-08 5:16 ` CK Hu
2022-08-08 5:21 ` CK Hu
2022-08-09 8:06 ` Bo-Chen Chen
2022-08-08 5:46 ` CK Hu
2022-08-09 7:57 ` Bo-Chen Chen
2022-08-08 5:50 ` CK Hu
2022-08-08 8:04 ` CK Hu
2022-08-09 8:01 ` Bo-Chen Chen
2022-08-05 10:14 ` [PATCH v16 4/8] drm/mediatek: Add MT8195 External DisplayPort support Bo-Chen Chen
2022-08-08 3:56 ` CK Hu
2022-08-05 10:14 ` [PATCH v16 5/8] drm/mediatek: add hpd debounce Bo-Chen Chen
2022-08-05 10:14 ` [PATCH v16 6/8] drm/mediatek: set monitor to DP_SET_POWER_D3 to avoid garbage Bo-Chen Chen
2022-08-05 10:14 ` [PATCH v16 7/8] drm/mediatek: DP audio support for MT8195 Bo-Chen Chen
2022-08-05 10:14 ` [PATCH v16 8/8] drm/mediatek: Use cached audio config when changing resolution Bo-Chen Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=759311a0e40401c3c0f230e700b00878daf81a87.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=liangxu.xu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=msp@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).