From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: pavel@ucw.cz, anthony.wong@canonical.com,
Dan Murphy <dmurphy@ti.com>,
"open list:LED SUBSYSTEM" <linux-leds@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] leds: core: Use blocking op for system suspend
Date: Thu, 2 Jul 2020 13:20:21 +0800 [thread overview]
Message-ID: <75B39716-5795-4F19-BC74-A4C21F99B85E@canonical.com> (raw)
In-Reply-To: <38622f5a-4518-cdb4-d1ca-581f470ce797@gmail.com>
> On Jul 2, 2020, at 05:28, Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote:
>
> Hi Kai-Heng,
>
> Thank you for the patch.
>
> On 7/1/20 11:35 AM, Kai-Heng Feng wrote:
>> Sometimes LED won't be turned off by LED_CORE_SUSPENDRESUME flag upon
>> system suspend.
>
> Just out of curiosity - are you experiencing that on some hardware?
Yes, mute and micmute LED on laptops sometimes are still on during suspend-to-idle.
>
>> led_set_brightness_nopm() uses schedule_work() to set LED brightness.
>> However, there's no guarantee that the scheduled work gets executed
>> because no one calls flush_scheduled_work().
>> As flush_scheduled_work() may affect other drivers' suspend routines,
>> take a more contained approach which uses blocking op to make sure the
>> LED gets turned off.
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> ---
>> drivers/leds/led-core.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>> diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
>> index f1f718dbe0f8..9a5bfcd7a704 100644
>> --- a/drivers/leds/led-core.c
>> +++ b/drivers/leds/led-core.c
>> @@ -269,6 +269,11 @@ EXPORT_SYMBOL_GPL(led_set_brightness);
>> void led_set_brightness_nopm(struct led_classdev *led_cdev,
>> enum led_brightness value)
>> {
>> +
>> + if (led_cdev->flags & LED_SUSPENDED &&
>> + !__led_set_brightness_blocking(led_cdev, value))
>> + return;
>> +
>
> This function is "nopm" for a reason - we do not make here any
> pm management related operations.
>
> Instead of that, please just add
>
> flush_work(&led_cdev->set_brightness_work);
>
> at the end of led_classdev_suspend()
>
> in drivers/leds/led-class.c.
Right, will send v2.
Kai-Heng
>
> --
> Best regards,
> Jacek Anaszewski
prev parent reply other threads:[~2020-07-02 5:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 9:35 [PATCH] leds: core: Use blocking op for system suspend Kai-Heng Feng
2020-07-01 21:28 ` Jacek Anaszewski
2020-07-02 5:20 ` Kai-Heng Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75B39716-5795-4F19-BC74-A4C21F99B85E@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=anthony.wong@canonical.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).