From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Paul Boddie <paul@boddie.org.uk>,
Maxime Ripard <maxime@cerno.tech>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-mips <linux-mips@vger.kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Paul Cercueil <paul@crapouillou.net>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Robert Foss <robert.foss@linaro.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes
Date: Wed, 2 Mar 2022 12:15:48 +0100 [thread overview]
Message-ID: <75CBD357-577A-402D-9E3B-DBE82A84BC43@goldelico.com> (raw)
In-Reply-To: <fca28594-8d4e-dd2f-93a0-a052cb888d90@baylibre.com>
Hi Neil,
> Am 02.03.2022 um 11:25 schrieb Neil Armstrong <narmstrong@baylibre.com>:
>
>> I added a printk for hdmi->sink_is_hdmi. This returns 1. Which IMHO is to be expected
>> since I am using a HDMI connector and panel... So your patch will still add the UYVY formats.
>> Either the synposys module inside the jz4780 or the panel does not understand them.
>
> By selecting the UYVY formats, the driver will enable the colorspace converters in the dw-hdmi IP,
> I don't see why it doesn't work here...
>
> There is a bit called `Support Color Space Converter` in config0_id:
> bit | Name | R/W | Desc
> 2 | csc | R | Indicates if Color Space Conversion block is present
>
> Could you dump all the config0 bits:
>
> =======================><=============================
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 54d8fdad395f..547731482da8 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -3431,6 +3431,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev,
> pdevinfo.id = PLATFORM_DEVID_AUTO;
>
> config0 = hdmi_readb(hdmi, HDMI_CONFIG0_ID);
> + dev_info(dev, "config0: %x\n", config0);
> config3 = hdmi_readb(hdmi, HDMI_CONFIG3_ID);
>
> if (iores && config3 & HDMI_CONFIG3_AHBAUDDMA) {
> =======================><=============================
>
> If this bit is missing, this would explain the black screen.
[ 9.291011] dw-hdmi-ingenic 10180000.hdmi: config0: bf
Hm. Or is the color-space conversion of the sw-hdmi module inside the jz4780 broken
or not configured properly?
(cross-checked: RGB mode still works if I force hdmi->sink_is_hdmi = false)
BR and thanks,
Nikolaus
next prev parent reply other threads:[~2022-03-02 11:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 17:12 [PATCH v16 0/4] MIPS: JZ4780 and CI20 HDMI H. Nikolaus Schaller
2022-02-26 17:12 ` [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll() H. Nikolaus Schaller
2022-03-03 16:23 ` Neil Armstrong
2022-03-03 16:30 ` H. Nikolaus Schaller
2022-03-03 16:43 ` [Letux-kernel] " H. Nikolaus Schaller
2022-03-03 16:51 ` Paul Cercueil
2022-03-03 17:09 ` H. Nikolaus Schaller
2022-03-03 17:20 ` Paul Cercueil
2022-03-03 17:59 ` H. Nikolaus Schaller
2022-03-04 13:30 ` Neil Armstrong
2022-03-04 16:47 ` Paul Cercueil
2022-03-04 17:51 ` H. Nikolaus Schaller
2022-03-04 18:04 ` Paul Cercueil
2022-03-04 18:15 ` H. Nikolaus Schaller
2022-03-04 18:33 ` Paul Cercueil
2022-03-04 18:41 ` H. Nikolaus Schaller
2022-03-05 7:49 ` H. Nikolaus Schaller
2022-03-03 16:46 ` Paul Cercueil
2022-03-03 17:05 ` H. Nikolaus Schaller
2022-02-26 17:13 ` [PATCH v16 2/4] drm/ingenic: Add dw-hdmi driver specialization for jz4780 H. Nikolaus Schaller
2022-02-26 17:13 ` [PATCH v16 3/4] drm/bridge: display-connector: add ddc-en gpio support H. Nikolaus Schaller
2022-02-26 17:13 ` [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes H. Nikolaus Schaller
2022-03-01 9:18 ` Neil Armstrong
2022-03-01 20:37 ` H. Nikolaus Schaller
2022-03-02 10:25 ` Neil Armstrong
2022-03-02 11:15 ` H. Nikolaus Schaller [this message]
2022-03-02 14:34 ` Neil Armstrong
2022-03-02 22:24 ` H. Nikolaus Schaller
2022-03-03 8:35 ` Neil Armstrong
2022-03-03 10:40 ` H. Nikolaus Schaller
2022-03-03 11:42 ` Neil Armstrong
2022-03-03 11:45 ` H. Nikolaus Schaller
2022-03-03 15:37 ` H. Nikolaus Schaller
2022-03-03 16:14 ` Neil Armstrong
2022-03-03 15:15 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75CBD357-577A-402D-9E3B-DBE82A84BC43@goldelico.com \
--to=hns@goldelico.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=paul@boddie.org.uk \
--cc=paul@crapouillou.net \
--cc=robert.foss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).