From: Dan Murphy <dmurphy@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: <robh+dt@kernel.org>, <jacek.anaszewski@gmail.com>,
<tony@atomide.com>, <lee.jones@linaro.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-leds@vger.kernel.org>
Subject: Re: [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc
Date: Thu, 14 Mar 2019 07:52:04 -0500 [thread overview]
Message-ID: <75def574-5fe4-46c0-664f-8c6583b69668@ti.com> (raw)
In-Reply-To: <20190314093912.GA10637@amd>
Hello
On 3/14/19 4:39 AM, Pavel Machek wrote:
> Hi!
>
> Could you maybe slow down a bit.
>
> "Hey, I should review this". "Hmm, there are two new versions in the
> mailbox in the meantime, good thing I waited."
>
Yes. I am going to hold off on v5 until the code gets reviewed.
>> + ramp-up-ms = <1024>;
>> + ramp-down-ms = <65536>;
>
> This is wrong.
>
Ack. Changed in it in the example I deleted.
>> + led@1 {
>> + reg = <1>;
>> + led-sources = <1>;
>> + ti,led-mode = <0>;
>> + label = "keypad";
>
> "platform::kbd_backlight"
Being an example does it have to match DT contents?
I can change it since I have to touch the file anyway.
Dan
> Pavel
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2019-03-14 12:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 12:32 [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Dan Murphy
2019-03-13 12:32 ` [PATCH v4 2/4] ARM: dts: omap4-droid4: Update backlight dt properties Dan Murphy
2019-03-13 12:32 ` [PATCH v4 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references Dan Murphy
2019-03-13 12:32 ` [PATCH v4 4/4] leds: lm3532: Introduce the lm3532 LED driver Dan Murphy
2019-03-20 12:39 ` Dan Murphy
2019-03-20 19:00 ` Jacek Anaszewski
2019-03-20 19:05 ` Dan Murphy
2019-03-20 18:59 ` Jacek Anaszewski
2019-03-20 19:04 ` Dan Murphy
2019-03-21 8:21 ` Lee Jones
2019-03-21 8:20 ` Lee Jones
2019-03-14 9:39 ` [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Pavel Machek
2019-03-14 12:52 ` Dan Murphy [this message]
2019-03-15 23:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75def574-5fe4-46c0-664f-8c6583b69668@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).