From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B136AC433FE for ; Mon, 13 Sep 2021 07:03:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FC0E60FE6 for ; Mon, 13 Sep 2021 07:03:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237550AbhIMHFL (ORCPT ); Mon, 13 Sep 2021 03:05:11 -0400 Received: from linux.microsoft.com ([13.77.154.182]:32958 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237492AbhIMHFJ (ORCPT ); Mon, 13 Sep 2021 03:05:09 -0400 Received: from [192.168.1.87] (unknown [223.184.74.135]) by linux.microsoft.com (Postfix) with ESMTPSA id A817120B713A; Mon, 13 Sep 2021 00:03:52 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A817120B713A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1631516634; bh=oXUTh+VKtreR97Vl7n/nyzvuA6UQzHaEaikohl+yWtk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=NQyfVnOQqcKtcvA4uC2JlSAWZB9hx351ivJX5BvOG6Xd3oA/3Pp20BkZ3v9Nu0whv NT5qReB1X+niABOU7qQ25ajY9RDiTn+PR9gTVLEFvcqKs+DViyoYLpNKunoZeiXAHD KrgBryp+5URNYe9xFboyBsi2mAF/pzqcZ1TMZ4sw= Subject: Re: [PATCH] blk-mq: export blk_mq_submit_bio symbol To: Christoph Hellwig Cc: Chaitanya Kulkarni , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "axboe@kernel.dk" , schakrabarti@linux.microsoft.com, lalita.muppana@microsoft.com References: <20210909053653.144360-1-kumarpraveen@linux.microsoft.com> <7e80b65b-51a4-3ca1-da43-e87612b8ca5f@nvidia.com> From: Praveen Kumar Message-ID: <75f77917-a8ba-0138-750b-8dedd8f7ce7d@linux.microsoft.com> Date: Mon, 13 Sep 2021 12:33:50 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13-09-2021 11:39, Christoph Hellwig wrote: > On Mon, Sep 13, 2021 at 09:54:54AM +0530, Praveen Kumar wrote: >>>> +EXPORT_SYMBOL_GPL(blk_mq_submit_bio); >>>> >>> >>> Where is the code that used this API ? >>> >> >> Thanks Chaitanya for your response. Please check my response to Christoph. >> That should give overall understanding of the use-case. > > Which really doesn't matter, while you keep ingoring the relevant > question. If you code is not upstream or at least actively being > submitted upstream your questions have no relevance whatsoever. > If you do not undertand that basic fact your are in the wrong place > here. > Hi Christoph, The upstream activity is being planned and will take sometime to reach to that state as we have to make it ready for latest kernel. To achieve the same, we were finding some solutions to handle latest changes. If you have scanned my previous email where I have provided a detail what the driver is doing, I did mention that we plan to use "blk_mq_submit_bio" but failed to do so, as code is not exported. So, to the specific answer, this API is NOT being used anywhere as of now. However, as you mentioned, the API cannot be exported for any specific driver, is there any solution or way if a custom driver wants to hook the existing bio path and massage it and then fall back to original flow ? Regards, ~Praveen.