From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751928AbcGLIUm (ORCPT ); Tue, 12 Jul 2016 04:20:42 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:49817 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbcGLIUj convert rfc822-to-8bit (ORCPT ); Tue, 12 Jul 2016 04:20:39 -0400 From: Arnd Bergmann To: Wan Zongshun Cc: devicetree@vger.kernel.org, jason@lakedaemon.net, Wan Zongshun , Daniel Lezcano , Russell King , linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, Thomas Gleixner , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/10] ARM: NUC900: Add nuc970 machine support Date: Tue, 12 Jul 2016 10:23:32 +0200 Message-ID: <7624955.nn13su4oq1@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <578498E7.4080709@iommu.org> References: <1468135649-19980-1-git-send-email-vw@iommu.org> <57847278.8000408@iommu.org> <578498E7.4080709@iommu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:RXqOb+cuguGpFuzw/0wmA8LC5mdp+0VwQgA8tKyyA/ikioCjIwb kulOuY/+WzG98Cc4gib7oZP9RW5ZrNh2hxeds/eawBagwlYIczULJGqVqRq/oVoldWAI8Rl fUMghyU4S0jUkdKkcYBONTOW67yMZs1cWOSFgJK0If8OaY6wB4Bjc2KE5TNIMO/2GQYfbes PiGCiguWcBBduHx+v0d7A== X-UI-Out-Filterresults: notjunk:1;V01:K0:ky/B8TZaFXE=:nmG2cDbSiuFF1ENuyqdRXm lgpNTEvbjReokYbRZYtqnWtLjQtjF+f4LrcXBdzJP0TidgLYDdA3nXUDYE9F29e+ptec7A0LI A+TB2p/5CSUthJkd1TF2czEDdgWeE5HbQnlYdo6TQk252+Vdta+ptCi1VGb7Y/GOx44o0zIt8 Pokf0WBjB76TBTBAdJdXteJ50WbR3qvYXMRXpa7kreWnGlUbVRxrlDKO6DG+8E2e7qecDGZxc Vtn3xtT1GEVg8wH2wi748VGuqYfLTa8LTjgTuMeaTkQgYMBml/Y3zJFK39VnxaU1OKF4nAy0n a6tZ6zSIelbs4TrbKah+28ZH576r+D4nxLr4w1abG8qFB6ekA4OgKTu8eUcXDle0a/TCeaB77 pcWPRmPhdnLqCBZEPTZZRS3hBqQdOqkIUneHYuhruchqmX2Cif+acUtAhnuO8gsC07eSTLM7n ys6rmC0wMIrQpYGoqe20a4gT0lGM6oTw/qx6BzKQYBMCbzEk5YaOxcPc9tkk1uDKqvkMCvRu3 sSLSjIwiWliLmZYrCAuKhbyAbYnP7YRM+YG4NWvyzl47nsce1qBKZq8OlkU2zm19Bdgr++6/l LZB45hIQERpDVpygcH33mBRRheXuwWZ+dVe2pP3wMMfsrszsgmTj4Ulp4Lykslm5Usly67UyQ /PgMhViPbNCK8V+x7dI2qDvvkiaQRgb8SdR5OcChOD88rs2gkCdQVEl7VpyOXWGXl+Kkh5xcR taPBWZSsfq2DbVMt Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, July 12, 2016 3:14:47 PM CEST Wan Zongshun wrote: > On 2016年07月12日 12:30, Wan Zongshun wrote: > > > > > > On 2016年07月12日 00:04, Arnd Bergmann wrote: > >> On Sunday, July 10, 2016 3:27:21 PM CEST Wan Zongshun wrote: > >>> +ifeq ($(CONFIG_SOC_NUC970),) > >>> obj-y := irq.o time.o mfp.o gpio.o clock.o > >>> obj-y += clksel.o dev.o cpu.o > >>> +endif > >>> # W90X900 CPU support files > >> > >> When mfp.o is disabled like this, I get a link error in two drivers > >> using the exported interface: > >> > >> ERROR: "mfp_set_groupg" [drivers/spi/spi-nuc900.ko] undefined! > >> ERROR: "mfp_set_groupi" [drivers/input/keyboard/w90p910_keypad.ko] > >> undefined! > > > > Why remove mfp modules? this multifunction pin driver should be used for > > those two drivers, if no mfp_set_groupX, I don't think driver can work. > > > > Now mfp has standard driver subsystem? > > > >> > >> Any idea for a better migration strategy? > > Arnd, If you still think the mfp should be removed, we can send a series > patches to instead of using mfp interface quickly, and do mfp set in > local driver. Do you think it is ok? I don't think setting it locally in the driver is a good idea. In the long run, this should go through the pinctrl framework, but there is no need to implement that right away. Until then, I think using the existing mfp.o code is fine, it will just need to be adapted slightly to understand the DT based device names. Arnd