From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966371AbbJ3LTh (ORCPT ); Fri, 30 Oct 2015 07:19:37 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:52010 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964769AbbJ3LTf (ORCPT ); Fri, 30 Oct 2015 07:19:35 -0400 From: Arnd Bergmann To: Daniel Lezcano Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Yoshinori Sato , "open list:OPEN FIRMWARE AND..." , "moderated list:H8/300 ARCHITECTURE" Subject: Re: [PATCH] Revert "h8300: clocksource" Date: Fri, 30 Oct 2015 12:19:08 +0100 Message-ID: <7633294.svub55eV7t@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1446200775-23898-1-git-send-email-daniel.lezcano@linaro.org> References: <1446200775-23898-1-git-send-email-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:NImamiW8y8Bzh4lTqP23mBgb2pozl9DmoGMyFSJjCy/N1ocmvwj 6yyPZDWL4q8q9rVrTzd60J5WKqNzTlsredaQemTL2RFmxsPQW9XTB6V1hnfH3zhYLKZnaLB jKYD0Sqfs31EDxmsUUfuq/UEWKP4E1jX6kCsUBJ7XGXQ86gZVQIhkvhPstS2GNGTkLRaz5h tBjqpY+d1RC8qVaY9KpjA== X-UI-Out-Filterresults: notjunk:1;V01:K0:k6CnPKQEhec=:fSTMFGcmeHOtEENHgJ66+8 WAoGxgwGjuPahgeRAFfAuYPmeqrlbdI6ApGkuTsunb5MX28aRjg4CIvl0RXzRsFi1mbUHsbKh WoSPLMM29OG7kRK89TcR8/ySW7MOUlpgguc8aSMErYLTvkcE2HfYWs33tnU8Yi2K89BeLB6Cs DrfYRc43+1KeCuh79DKmxQW4MZz+LwwOY5qyA87CznqdZXYdhezjeWw1Cb02G6+7C4KfOTQjI /pA6Oj18JbB5VH5wzBmEMEWR9KMxQFzQTMYXrhduh20x5piR8K90tfdnMIEAigCn1NnSpbGkW hO0Jvc8/aau+/AX+bm2BxIa4wvRHwRnFKPZU2Ut+N60k4d51yVxMG7IpGAnytg8anUBKyieNR fjF8QSVusdhpM1amjyeIHrBgLceuHx1sQ1GpZ5vLUBX8rUNPrn3g0QpGhYBCqwQHeNLE2FCTp /FQw7H+GauqNOYx5yebYPurI+lLMlofDXkDcsXIeFqtXpBdpJwSsZ7VHJuOquH/nJr3S/tEgV ly7XDCJKG8aU1JPehrR5PaK2kxUCYHJBTu7XKUk6kOte0YBlhtAZwXgmCz1MM5igTPZ/aZc/1 +/S9fblxJ+yfQdsBUMItmLbe5RW1z/6n+/dLG8Zve3Tx+HcdKUw+Q8OeSYJkwzVDbIcTzZSIW 0eFltV8ze8gMRat6+W/tuMCWk/GJ+mFZsbNp+up7mXQNmaKh5OoChz97u0lG/iV2tOXxjI2lW aVPVzgtGKCxohv3r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 30 October 2015 11:26:08 Daniel Lezcano wrote: > This reverts commit 618b902d8c098f2fff188119da7b3184c4bc5483. > > The renesas architecture have been dropped and re-introduced two years > after with a supposed improvement of the code. > > While looking at the timer drivers, I see it did not passed a correct code > review process. No maintainters were in Cc, not code review and no ack > from them (Thomas and I). > > Even if those drivers where already in the tree several years ago, that > does not prevent them, when re-introduced, to be reviewed again and at > least acked by the maintainer. > > Even if the patches where on lkml@, that does not prevent the different > sub-system maintainers to be in Cc. Agreed. > Instead of that, these drivers passed silently through another tree (arm-soc > I guess). No need to speculate when you can look it up easily (it wasn't us): $ git log --oneline --merges --ancestry-path 618b902d8c098f2fff188119da7b3184c4bc5483.. | tail -n1 55a7d4b85ca1 Merge tag 'for-4.2' of git://git.sourceforge.jp/gitroot/uclinux-h8/linux $ git show 55a7d4b85ca1 commit 55a7d4b85ca1f723d26b8956e8faeff730d0d240 Merge: aefbef10e3ae 07834743f42b Author: Linus Torvalds Date: Thu Jun 25 13:07:24 2015 -0700 Merge tag 'for-4.2' of git://git.sourceforge.jp/gitroot/uclinux-h8/linux Pull Renesas H8/300 architecture re-introduction from Yoshinori Sato. We dropped arch/h8300 two years ago as stale and old, this is a new and more modern rewritten arch support for the same architecture. I reviewed the series before it was merged, but failed to notice that you were not on Cc, and I did not look at the clocksource drivers in much detail (if at all). > There is legacy code to be removed. > > Signed-off-by: Daniel Lezcano I found that Yoshinori Sato has always addressed all review comments very quickly by rewriting the code in a proper manner when mistakes were pointed out in the other drivers. Maybe you can describe now what the problems are with the three drivers to give him a chance to fix them? Arnd