From: Kumar Gala <kumar.gala@freescale.com>
To: "Russell King" <rmk+lkml@arm.linux.org.uk>
Cc: "Linux Kernel list" <linux-kernel@vger.kernel.org>,
"Greg KH" <greg@kroah.com>
Subject: Re: serial8250_init and platform_device
Date: Thu, 20 Jan 2005 14:25:44 -0600 [thread overview]
Message-ID: <763C3603-6B21-11D9-BD44-000393DBC2E8@freescale.com> (raw)
In-Reply-To: <20050120201059.I13242@flint.arm.linux.org.uk>
agreed, the lack of a delimiter in the naming was annoying.
- kumar
On Jan 20, 2005, at 2:10 PM, Russell King wrote:
> On Thu, Jan 20, 2005 at 11:50:58AM -0800, Greg KH wrote:
> > On Thu, Jan 20, 2005 at 07:38:45PM +0000, Russell King wrote:
> > >
> > > Greg - the name is constructed from "name" + "id num" thusly:
> > >
> > > serial8250
> > > serial82500
> > > serial82501
> > > serial82502
> > >
> > > When "name" ends in a number, it gets rather confusing. Can we
> have
> > > an optional delimiter in there when we append the ID number, maybe
> > > something like a '.' or ':' ?
> >
> > Sure, that's fine with me. Someone send me a patch :)
>
> Like this?
> -
>
> Separate platform device name from platform device number such that
> names ending with numbers aren't confusing.
>
> Signed-off-by: Russell King <rmk@arm.linux.org.uk>
>
> --- orig/drivers/base/platform.c Wed Jan 12 10:11:20 2005
> +++ linux/drivers/base/platform.c Thu Jan 20 20:08:53 2005
> @@ -131,7 +131,7 @@ int platform_device_register(struct plat
> pdev->dev.bus = &platform_bus_type;
>
> if (pdev->id != -1)
> - snprintf(pdev->dev.bus_id, BUS_ID_SIZE, "%s%u",
> pdev->name, pdev->id);
> + snprintf(pdev->dev.bus_id, BUS_ID_SIZE, "%s.%u",
> pdev->name, pdev->id);
> else
> strlcpy(pdev->dev.bus_id, pdev->name, BUS_ID_SIZE);
>
>
> --
> Russell King
> Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
> maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
> 2.6 Serial core
next prev parent reply other threads:[~2005-01-20 20:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-20 7:14 serial8250_init and platform_device Kumar Gala
2005-01-20 11:43 ` Russell King
2005-01-20 15:23 ` Kumar Gala
2005-01-20 15:44 ` Russell King
2005-01-20 19:06 ` Kumar Gala
2005-01-20 19:38 ` Russell King
2005-01-20 19:50 ` Greg KH
2005-01-20 20:10 ` Russell King
2005-01-20 20:25 ` Kumar Gala [this message]
2005-02-01 8:41 ` Greg KH
2005-01-20 20:26 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=763C3603-6B21-11D9-BD44-000393DBC2E8@freescale.com \
--to=kumar.gala@freescale.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).