linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: <shifu0704@thundersoft.com>, <lgirdwood@gmail.com>,
	<broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
	<linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>
Cc: <navada@ti.com>
Subject: Re: [PATCH] tas2770: add tas2770 smart PA dt bindings
Date: Tue, 10 Sep 2019 08:21:25 -0500	[thread overview]
Message-ID: <76759c2c-3f5d-5cf6-fc2b-feb1dc8c0e6a@ti.com> (raw)
In-Reply-To: <1567753564-13699-1-git-send-email-shifu0704@thundersoft.com>

Shi

On 9/6/19 2:06 AM, shifu0704@thundersoft.com wrote:
> From: Frank Shi <shifu0704@thundersoft.com>

Subject should be

dt-bindings: ASoC: Add tas2770 smart PA dt bindings

Also Please add Rob Herring <robh+dt@kernel.org> for review

> add tas2770 smart PA dt bindings
>
> Signed-off-by: Frank Shi <shifu0704@thundersoft.com>
> ---
>   Documentation/devicetree/bindings/tas2770.txt | 38 +++++++++++++++++++++++++++
>   1 file changed, 38 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/tas2770.txt
>
> diff --git a/Documentation/devicetree/bindings/tas2770.txt b/Documentation/devicetree/bindings/tas2770.txt
> new file mode 100644
> index 0000000..f70b310
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/tas2770.txt
> @@ -0,0 +1,38 @@
> +Texas Instruments TAS2770 Smart PA
> +
> +The TAS2770 is a mono, digital input Class-D audio amplifier optimized for
> +efficiently driving high peak power into small loudspeakers.
> +Integrated speaker voltage and current sense provides for
> +real time monitoring of loudspeaker behavior.
> +
> +Required properties:
> +
> + - compatible:	   - Should contain "ti,tas2770".
> + - reg:		       - The i2c address. Should contain <0x4c>, <0x4d>,<0x4e>, or <0x4f>.
s/should/may
> + - #address-cells  - Should be <1>.
> + - #size-cells     - Should be <0>.
> + - ti,asi-format:  - Sets TDM RX capture edge. 0->Rising; 1->Falling.
> + - ti,left-slot:   - Sets TDM RX left time slots.
> + - ti,right-slot:  - Sets TDM RX right time slots.
> + - ti,imon-slot-no:- TDM TX current sense time slot.
> + - ti,vmon-slot-no:- TDM TX voltage sense time slot.
> +
> +Optional properties:
> +
> + - reset-gpio:	Reset GPIO number of left device.
> + - irq-gpio:  IRQ GPIO number of left device.

You might want to use

- interrupt-parent: the phandle to the interrupt controller which provides
                     the interrupt.
- interrupts: interrupt specification for data-ready.

Instead of irq-gpio

> +
> +Examples:
> +
> +    tas2770@4c {
> +                compatible = "ti,tas2770";
> +                reg = <0x4c>;

Missing

#address-cells = <1>;

#size-cells = <0>;

> +                reset-gpio = <&gpio15 1 GPIO_ACTIVE_LOW>;
> +                irq-gpio = <&gpio16 1 GPIO_ACTIVE_LOW>;
> +                ti,asi-format = <0>;
> +                ti,left-slot = <0>;
> +                ti,right-slot = <1>;
> +                ti,imon-slot-no = <0>;
> +                ti,vmon-slot-no = <2>;
> +        };
> +

Suggestion to provide the URL to the data sheet.


  parent reply	other threads:[~2019-09-10 13:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06  7:06 shifu0704
2019-09-06  7:06 ` [PATCH] tas2770: add tas2770 smart PA kernel driver shifu0704
2019-09-10 12:33   ` Mark Brown
2019-09-10 13:58   ` Dan Murphy
2019-09-10 11:37 ` [PATCH] tas2770: add tas2770 smart PA dt bindings Mark Brown
2019-09-10 13:21 ` Dan Murphy [this message]
2019-09-10 13:47   ` Dan Murphy
2019-09-11 10:01   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76759c2c-3f5d-5cf6-fc2b-feb1dc8c0e6a@ti.com \
    --to=dmurphy@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=navada@ti.com \
    --cc=perex@perex.cz \
    --cc=shifu0704@thundersoft.com \
    --cc=tiwai@suse.com \
    --subject='Re: [PATCH] tas2770: add tas2770 smart PA dt bindings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).