From: "Nikunj Kela (nkela)" <nkela@cisco.com>
To: "jeffrey.t.kirsher@intel.com" <jeffrey.t.kirsher@intel.com>
Cc: "xe-linux-external(mailer list)" <xe-linux-external@cisco.com>,
"David S. Miller" <davem@davemloft.net>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] igb: add parameter to ignore nvm checksum validation
Date: Thu, 16 May 2019 19:55:16 +0000 [thread overview]
Message-ID: <76B41175-0CEE-466C-91BF-89A1CA857061@cisco.com> (raw)
In-Reply-To: <9be117dc6e818ab83376cd8e0f79dbfaaf193aa9.camel@intel.com>
On 5/16/19, 12:35 PM, "Jeff Kirsher" <jeffrey.t.kirsher@intel.com> wrote:
On Wed, 2019-05-08 at 23:14 +0000, Nikunj Kela wrote:
>> Some of the broken NICs don't have EEPROM programmed correctly. It
>> results
>> in probe to fail. This change adds a module parameter that can be
>> used to
>> ignore nvm checksum validation.
>>
>> Cc: xe-linux-external@cisco.com
>> Signed-off-by: Nikunj Kela <nkela@cisco.com>
>> ---
>> drivers/net/ethernet/intel/igb/igb_main.c | 28
>> ++++++++++++++++++++++------
>> 1 file changed, 22 insertions(+), 6 deletions(-)
>NAK for two reasons. First, module parameters are not desirable
>because their individual to one driver and a global solution should be
>found so that all networking device drivers can use the solution. This
>will keep the interface to change/setup/modify networking drivers
>consistent for all drivers.
>Second and more importantly, if your NIC is broken, fix it. Do not try
>and create a software workaround so that you can continue to use a
>broken NIC. There are methods/tools available to properly reprogram
>the EEPROM on a NIC, which is the right solution for your issue.
I am proposing this as a debug parameter. Obviously, we need to fix EEPROM but this helps us continuing the development while manufacturing fixes NIC.
next prev parent reply other threads:[~2019-05-16 19:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 23:14 [PATCH] igb: add parameter to ignore nvm checksum validation Nikunj Kela
2019-05-16 19:35 ` Jeff Kirsher
2019-05-16 19:55 ` Nikunj Kela (nkela) [this message]
2019-05-16 22:02 ` Florian Fainelli
2019-05-16 22:33 ` Nikunj Kela (nkela)
2019-05-17 1:03 ` Daniel Walker
2019-05-17 1:48 ` Florian Fainelli
2019-05-17 15:16 ` [Intel-wired-lan] " Alexander Duyck
2019-05-17 16:36 ` Daniel Walker
2019-05-17 16:47 ` Florian Fainelli
2019-05-17 16:58 ` Alexander Duyck
2019-05-17 18:09 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76B41175-0CEE-466C-91BF-89A1CA857061@cisco.com \
--to=nkela@cisco.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).