From: Luis Oliveira <Luis.Oliveira@synopsys.com>
To: Wolfram Sang <wsa@the-dreams.de>,
Ramiro Oliveira <Ramiro.Oliveira@synopsys.com>
Cc: Mark Rutland <mark.rutland@arm.com>, <Luis.Oliveira@synopsys.com>,
<jarkko.nikula@linux.intel.com>,
<andriy.shevchenko@linux.intel.com>,
<mika.westerberg@linux.intel.com>, <linux-i2c@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
<devicetree@vger.kernel.org>, <CARLOS.PALMINHA@synopsys.com>
Subject: Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported
Date: Fri, 21 Oct 2016 10:56:24 +0100 [thread overview]
Message-ID: <76ab13e9-9aa5-97c3-2328-928bbcef9877@synopsys.com> (raw)
In-Reply-To: <20161018151706.GA1433@katana>
Since practically 90% of the code is shared between master and slave, I was
thinking if it will be acceptable to use the same driver for both but
differentiate the master/slave mode by the compatible strings.
Thanks,
Luis
On 10/18/2016 16:17, Wolfram Sang wrote:
>> This is needed because the configuration is different and the i2c-designware
>> cannot be master/slave without a reset. To resolve that I added this property
>> to bind it as a slave when needed.
> Aww, pity that the HW can't do that. Do you have details why?
>
> If that is really a HW limitation, then I'd suggest having a seperate
> driver for slave-only mode so we can differentiate by compatible
> strings.
>
next prev parent reply other threads:[~2016-10-21 9:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 16:52 [PATCH v2 0/4] Add slave mode to Synopsys I2C driver Luis.Oliveira
2016-10-14 16:52 ` [PATCH v2 1/4] Factor out _master() parts of code and identify as much as possible all related with MASTER mode Luis.Oliveira
2016-10-21 10:37 ` Andy Shevchenko
2016-10-14 16:52 ` [PATCH v2 2/4] Added I2C_SLAVE as a dependency to I2C_DESIGNWARE_CORE Enable _slave() mode Review of the pm_runtime...() methods and cleaning Luis.Oliveira
2016-10-21 10:52 ` Andy Shevchenko
2016-10-14 16:52 ` [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported Luis.Oliveira
2016-10-14 17:30 ` Mark Rutland
2016-10-14 18:20 ` Wolfram Sang
[not found] ` <55cc91af-8d24-8aea-f74f-2ef40cd8ea5a@synopsys.com>
2016-10-18 15:17 ` Wolfram Sang
2016-10-21 9:56 ` Luis Oliveira [this message]
2016-10-21 10:54 ` Andy Shevchenko
2016-11-08 14:18 ` Luis Oliveira
2016-10-18 14:50 ` Ramiro Oliveira
2016-10-18 14:33 ` Rob Herring
2016-10-14 16:52 ` [PATCH v2 4/4] Cleaned the code, no functional changes Luis.Oliveira
2016-10-21 10:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76ab13e9-9aa5-97c3-2328-928bbcef9877@synopsys.com \
--to=luis.oliveira@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).