From: Sergey Dyasli <sergey.dyasli@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
<xen-devel@lists.xen.org>, <kasan-dev@googlegroups.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
George Dunlap <george.dunlap@citrix.com>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
Andrew Morton <akpm@linux-foundation.org>,
"sergey.dyasli@citrix.com >> Sergey Dyasli"
<sergey.dyasli@citrix.com>
Subject: Re: [PATCH v1 2/4] x86/xen: add basic KASAN support for PV kernel
Date: Fri, 10 Jan 2020 11:46:45 +0000 [thread overview]
Message-ID: <76cf8b94-6f71-9f8c-0fc9-07ad4aded3be@citrix.com> (raw)
In-Reply-To: <5214cb54-1719-f93b-130f-90c5da31e22a@oracle.com>
On 09/01/2020 23:27, Boris Ostrovsky wrote:
>
>
> On 1/8/20 10:20 AM, Sergey Dyasli wrote:
>> @@ -1943,6 +1973,15 @@ void __init xen_setup_kernel_pagetable(pgd_t *pgd, unsigned long max_pfn)
>> if (i && i < pgd_index(__START_KERNEL_map))
>> init_top_pgt[i] = ((pgd_t *)xen_start_info->pt_base)[i];
>> +#ifdef CONFIG_KASAN
>> + /*
>> + * Copy KASAN mappings
>> + * ffffec0000000000 - fffffbffffffffff (=44 bits) kasan shadow memory (16TB)
>> + */
>> + for (i = 0xec0 >> 3; i < 0xfc0 >> 3; i++)
>
> Are you referring here to KASAN_SHADOW_START and KASAN_SHADOW_END? If so, can you use them instead?
Indeed, the following macros make the code neater:
#ifdef CONFIG_KASAN
/* Copy KASAN mappings */
for (i = pgd_index(KASAN_SHADOW_START);
i < pgd_index(KASAN_SHADOW_END);
i++)
init_top_pgt[i] = ((pgd_t *)xen_start_info->pt_base)[i];
#endif /* ifdef CONFIG_KASAN */
--
Thanks,
Sergey
next prev parent reply other threads:[~2020-01-10 11:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 15:20 [PATCH v1 0/4] basic KASAN support for Xen PV domains Sergey Dyasli
2020-01-08 15:20 ` [PATCH v1 1/4] kasan: introduce set_pmd_early_shadow() Sergey Dyasli
2020-01-10 14:41 ` kbuild test robot
2020-01-11 5:21 ` kbuild test robot
2020-01-15 10:54 ` Sergey Dyasli
2020-01-15 11:09 ` Jürgen Groß
2020-01-15 16:32 ` Sergey Dyasli
2020-01-16 7:54 ` Jürgen Groß
2020-01-08 15:20 ` [PATCH v1 2/4] x86/xen: add basic KASAN support for PV kernel Sergey Dyasli
2020-01-09 9:15 ` Jürgen Groß
2020-01-10 11:07 ` Sergey Dyasli
2020-01-09 23:27 ` Boris Ostrovsky
2020-01-10 11:46 ` Sergey Dyasli [this message]
2020-01-10 13:05 ` kbuild test robot
2020-01-10 17:19 ` kbuild test robot
2020-01-08 15:20 ` [PATCH v1 3/4] xen: teach KASAN about grant tables Sergey Dyasli
2020-01-08 15:21 ` [PATCH v1 4/4] xen/netback: Fix grant copy across page boundary with KASAN Sergey Dyasli
2020-01-09 10:33 ` Vlastimil Babka
2020-01-15 11:02 ` Sergey Dyasli
2020-01-09 13:36 ` Paul Durrant
2020-01-10 14:27 ` Sergey Dyasli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76cf8b94-6f71-9f8c-0fc9-07ad4aded3be@citrix.com \
--to=sergey.dyasli@citrix.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dvyukov@google.com \
--cc=george.dunlap@citrix.com \
--cc=glider@google.com \
--cc=jgross@suse.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).