linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jing Leng" <3090101217@zju.edu.cn>
To: "Greg KH" <gregkh@linuxfoundation.org>
Cc: balbi@kernel.org, ruslan.bilovol@gmail.com,
	pavel.hofman@ivitera.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, "Jing Leng" <jleng@ambarella.com>
Subject: Re: [PATCH] usb: gadget: f_uac1: add set requests support
Date: Thu, 17 Feb 2022 09:42:00 +0800 (GMT+08:00)	[thread overview]
Message-ID: <770c0d3f.ab34b.17f0557e359.Coremail.3090101217@zju.edu.cn> (raw)
In-Reply-To: <YgzTsLV/nSKp7FWP@kroah.com>

Hi Greg KH,

> So is this a bug in the Host side to not do stuff like this?  Why not
> fix it there instead?
> 
> Where is the requirement that this command must be handled by the
> device?
> 

First we need to clarify two issues.

1. Does the Ubuntu go beyond the UAC1 specification?
No. 
On page 66 of the UAC1 specification (
https://www.usb.org/sites/default/files/audio10.pdf):
The bRequest can be SET_CUR, SET_MIN, SET_MAX, SET_RES or SET_MEM.
In most cases, only the CUR and MEM attribute will be supported for
the Set request. However, this specification does not prevent a
designer from making other attributes programmable.
Supplement: Windows 10 only sends SET_CUR request.

2. Does the old version kernel have the problem on the Ubuntu?
NO. (e.g. linux-5.10)
The problem is introduced by the following modification:
    commit 0356e6283c7177391d144612f4b12986ed5c4f6e
    Author: Ruslan Bilovol <ruslan.bilovol@gmail.com>
    Date:   Mon Jul 12 14:55:29 2021 +0200

        usb: gadget: f_uac1: add volume and mute support

Since Ubuntu doesn't go beyond the UAC1 specification and the problem
is introduced by new version kernel, Why don't we perfect it on 
kernel side?

Thanks
Jing Leng

  reply	other threads:[~2022-02-17  1:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16  9:43 [PATCH] usb: gadget: f_uac1: add set requests support 3090101217
2022-02-16 10:36 ` Greg KH
2022-02-17  1:42   ` Jing Leng [this message]
2022-02-17 15:28     ` Greg KH
2022-02-18  9:49       ` [PATCH v2] " 3090101217

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=770c0d3f.ab34b.17f0557e359.Coremail.3090101217@zju.edu.cn \
    --to=3090101217@zju.edu.cn \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jleng@ambarella.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pavel.hofman@ivitera.com \
    --cc=ruslan.bilovol@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).