From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbcGCICb (ORCPT ); Sun, 3 Jul 2016 04:02:31 -0400 Received: from mout.web.de ([212.227.15.3]:58836 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbcGCIC1 (ORCPT ); Sun, 3 Jul 2016 04:02:27 -0400 Subject: Re: [PATCH 0/2] Input-at32psif: Fine-tuning for OOM handling in psif_probe() To: Joe Perches , Dmitry Torokhov , linux-input@vger.kernel.org References: <566ABCD9.1060404@users.sourceforge.net> <4471604f-f401-bed9-39be-1aff2a92edf6@users.sourceforge.net> <1467492333.1968.5.camel@perches.com> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <7748f752-297e-fe5f-0517-eb65e2deec65@users.sourceforge.net> Date: Sun, 3 Jul 2016 10:01:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <1467492333.1968.5.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:r57eqQWkJs2FAjyge2suKI89IBliuFN3pQCltKNvyl/+Fp7e+dp Qdwd0APbQGiN5aObLlsSyDVcDYc1vsLT4bIF+xNWE29g9n+WodshSxSC9umBq7LLX6EY7zK ss6XyZFDBJfRbfYhCFC2Gb+1y/pRVwW5V+G1UAATnNBin82m+WzION6fOVmwPIRVe4b2Q5x pz0c5wlsPUBtFQ/i/UStg== X-UI-Out-Filterresults: notjunk:1;V01:K0:9nmmkjqAtfs=:z4bPSMgohGUKLWV66t4IVG vNjMxjxKvAAVdhQG5EmUmFlXzz0AxZNm/2Q6UtlPSPAW2YigU7/Fcp+aoJ3S+FxPub1x5GyqX mbv5GYZX6B0jM/INsq0cIrpaUe6XPj8z29HZhwMQI1ozWutogP/PLv8A5tltAcj/V3ffrul68 9URYqgEwVdbrvCIYq9im3bSdmAIeCPVaykaPBF+iKooPS5RbzGv6CEQNpELRzEhRZPnLfCgw2 vr0Q28GLuWwjaAsxkQJDeUpfeUGEp6J5thPjy7sEdGy3qAYpvDIu+kdTW3+fnMvVcct/yOKhv CvxELdWYiLPHZ+Q/bD/Uj0ppv5Tyv0r1acEX5mcNVcRTfMGHoOr8z7sasJdTsQ6bTVHhH9olL 1bu83enKbNXsBtlNIEyzH+F8Ojiy4KfJBREmd1ZHCFAZKUuEiOBIMN0aS4kUpvjhybxS+jKNh HZn06zRESWPk6+cu+UIgUebWKdezxUQbKVbGx28r68SMwAKHvUuw5CwZC6q5lrKOHa1HL+PDk iQpPT9HmN+gZVowBFu1Olz/QfcyLc/MB/fr2sEMibbQME19E/kmG2RyRme1m2lO5ifi+xNjvP QgWh93ENdSnkS3QLIdH2845Yityb9yOgTe5enjYCtIOoGZzovtqL+Pf8ExnR//H7n22tW7WJQ 7htn52BfJYtGJlCJPv7ATNjapLxtWGTPGY4/xRFG2S/PyuZmECe9bJLgpzyTTrjGYeusPLmLV 1pq0jgJeDPRvEwdY2+jxxAaUj7/wQdv4sjSRSwOQLOy5GM965/OXAS9qoSJHYGOY38ly/C5sL CVy5/6q Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> A few update suggestions were taken into account >> from static source code analysis. >> >> Markus Elfring (2): >> Return directly after a failed kzalloc() >> Remove two OOM messages >> >> drivers/input/serio/at32psif.c | 10 +++------- >> 1 file changed, 3 insertions(+), 7 deletions(-) > > What possible rationale is there for including this "references" header? > 566ABCD9.1060404@users.sourceforge.net Do any more software developers dare to reconsider source code also around a jump label like "out"? > This message id is for your message: > "Source code review around jump label usage" > sent December 11, 2015! Can such an association with a bit of background information be occasionally useful for clarification of corresponding implementation details? Regards, Markus