From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7801BC433E0 for ; Mon, 18 May 2020 21:08:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5223820715 for ; Mon, 18 May 2020 21:08:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728065AbgERVIf (ORCPT ); Mon, 18 May 2020 17:08:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726270AbgERVIf (ORCPT ); Mon, 18 May 2020 17:08:35 -0400 Received: from omr1.cc.vt.edu (omr1.cc.ipv6.vt.edu [IPv6:2607:b400:92:8300:0:c6:2117:b0e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB119C061A0C for ; Mon, 18 May 2020 14:08:34 -0700 (PDT) Received: from mr3.cc.vt.edu (mr3.cc.vt.edu [IPv6:2607:b400:92:8500:0:7f:b804:6b0a]) by omr1.cc.vt.edu (8.14.4/8.14.4) with ESMTP id 04IL8Y3f008037 for ; Mon, 18 May 2020 17:08:34 -0400 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mr3.cc.vt.edu (8.14.7/8.14.7) with ESMTP id 04IL8Tb9011082 for ; Mon, 18 May 2020 17:08:34 -0400 Received: by mail-qt1-f197.google.com with SMTP id e44so13478452qta.9 for ; Mon, 18 May 2020 14:08:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:mime-version:date :message-id; bh=kM/2TLwbOWyz4JRQ8aP48mBwa+htNbB3MxdeeuZE8tM=; b=bS8lNm6IVTiJCAJHLoAoMAgrB2UCYhduyzAqEaUqGrp/paSM3XIkpTwboLO4WVS7m/ zw6DwsZsz/CghkkAbwM123Wmb5X/kGU/esbV16ot9yt3UZhc48MdxYIzpTQYO3spXMH9 dz9M5/FY13+XGEfVagextAfXBQ9EbOxI7oPWzCz8LfUrdCks6AWFizAsxgqYosOwPCL6 vuN8eO5q0G0CT/fdj+qMa+clau5msg10rHHIKMa0YN3irMTAeT5D4v0/ORXZyHhVdK60 kY8kObHre3xIyBZIq2tv3lziah71ovuDAEnse4+E4b+0+lrtshRVdPYh0nmvCIYz0tVX ie4A== X-Gm-Message-State: AOAM533PdA/Fr6fmqs7dICbN2ay6/5mx/USE6qPIhfJiDkefyjsEIVFU BqzAtPm3cXhd+LPYQQAKaQ2JGqYiFZOCcDpmvbSSJcOqyNWLicmyLWZHo2M5qQkQ/Yuo/6owuzu WlV5LWaRmAhjxLVdwr7jRjYQsJmWa/dB9mCM= X-Received: by 2002:a05:620a:1e:: with SMTP id j30mr18210090qki.470.1589836108919; Mon, 18 May 2020 14:08:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXD+xC5+XKAl2RVDYaqJrxN/4ysReFfKpWWyp/+kjyPqs4ASEt78jxmru36a7x0DnMQdTyWg== X-Received: by 2002:a05:620a:1e:: with SMTP id j30mr18210074qki.470.1589836108615; Mon, 18 May 2020 14:08:28 -0700 (PDT) Received: from turing-police ([2601:5c0:c001:c9e1::359]) by smtp.gmail.com with ESMTPSA id o3sm10085708qtt.56.2020.05.18.14.08.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 14:08:27 -0700 (PDT) From: "Valdis =?utf-8?Q?Kl=c4=93tnieks?=" X-Google-Original-From: "Valdis =?utf-8?Q?Kl=c4=93tnieks?=" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Sivaprakash Murugesan , Andy Gross , Bjorn Andersson , Ohad Ben-Cohen , Philipp Zabel cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] remoteproc: wcss: Fix function call for new API Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 18 May 2020 17:08:26 -0400 Message-ID: <77652.1589836106@turing-police> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit 8a226e2c71: remoteproc: wcss: add support for rpmsg communication throws a compile error: CC [M] drivers/remoteproc/qcom_q6v5_wcss.o drivers/remoteproc/qcom_q6v5_wcss.c: In function 'q6v5_wcss_probe': drivers/remoteproc/qcom_q6v5_wcss.c:563:2: error: too few arguments to function 'qcom_add_glink_subdev' qcom_add_glink_subdev(rproc, &wcss->glink_subdev); ^~~~~~~~~~~~~~~~~~~~~ In file included from drivers/remoteproc/qcom_q6v5_wcss.c:16: drivers/remoteproc/qcom_common.h:35:6: note: declared here void qcom_add_glink_subdev(struct rproc *rproc, struct qcom_rproc_glink *glink, ^~~~~~~~~~~~~~~~~~~~~ Update to API change from commit cd9fc8f: remoteproc: qcom: Pass ssr_name to glink subdevice Signed-off-by: Valdis Kletnieks diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c index 48d16d81f94d..99ecc0e6276e 100644 --- a/drivers/remoteproc/qcom_q6v5_wcss.c +++ b/drivers/remoteproc/qcom_q6v5_wcss.c @@ -560,7 +560,7 @@ static int q6v5_wcss_probe(struct platform_device *pdev) if (ret) goto free_rproc; - qcom_add_glink_subdev(rproc, &wcss->glink_subdev); + qcom_add_glink_subdev(rproc, &wcss->glink_subdev,"q6wcss"); qcom_add_ssr_subdev(rproc, &wcss->ssr_subdev, "q6wcss"); ret = rproc_add(rproc);