From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFECDC433FE for ; Wed, 18 May 2022 13:40:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238127AbiERNkj (ORCPT ); Wed, 18 May 2022 09:40:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238078AbiERNkh (ORCPT ); Wed, 18 May 2022 09:40:37 -0400 Received: from relay02.th.seeweb.it (relay02.th.seeweb.it [IPv6:2001:4b7a:2000:18::163]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7389A6353C for ; Wed, 18 May 2022 06:40:35 -0700 (PDT) Received: from [10.1.250.9] (riviera.nat.ds.pw.edu.pl [194.29.137.1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id F3BBD2060E; Wed, 18 May 2022 15:40:31 +0200 (CEST) Message-ID: <77726e82-eaef-4cce-514a-1df04e5c33ee@somainline.org> Date: Wed, 18 May 2022 15:40:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 5/6] arm64: dts: ipq8074: add SPMI PMP8074 PMIC regulators To: Robert Marko , agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220517205341.536587-1-robimarko@gmail.com> <20220517205341.536587-5-robimarko@gmail.com> From: Konrad Dybcio In-Reply-To: <20220517205341.536587-5-robimarko@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/05/2022 22:53, Robert Marko wrote: > PMP8074 is used in IPQ8074 and provides S3 for cores, > S4 for UBI core and LDO11 for SDIO/eMMC. > > So, lets add the nodes in preparation for DVFS later. > > Signed-off-by: Robert Marko > --- > arch/arm64/boot/dts/qcom/ipq8074.dtsi | 34 +++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi > index 789fec7c6aa4..d1a0b77c38a4 100644 > --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > model = "Qualcomm Technologies, Inc. IPQ8074"; > @@ -421,6 +422,39 @@ spmi_bus: spmi@200f000 { > interrupt-controller; > #interrupt-cells = <4>; > cell-index = <0>; > + > + pmic@1 { Hi! These nodes belong in the PMIC DTSI (check pm8150.dtsi and others alike for reference). Konrad > + compatible ="qcom,spmi-pmic"; > + reg = <0x1 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + regulators { > + compatible = "qcom,pmp8074-regulators"; > + > + s3: s3 { > + regulator-name = "vdd_s3"; > + regulator-min-microvolt = <592000>; > + regulator-max-microvolt = <1064000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + s4: s4 { > + regulator-name = "vdd_s4"; > + regulator-min-microvolt = <712000>; > + regulator-max-microvolt = <992000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + l11: l11 { > + regulator-name = "l11"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + }; > + }; > + }; > }; > > sdhc_1: sdhci@7824900 { >