From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5AA5C54FD7 for ; Wed, 25 Mar 2020 15:11:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 968F320789 for ; Wed, 25 Mar 2020 15:11:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=flygoat.com header.i=jiaxun.yang@flygoat.com header.b="eEeJkPVL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727598AbgCYPLa (ORCPT ); Wed, 25 Mar 2020 11:11:30 -0400 Received: from sender3-op-o12.zoho.com.cn ([124.251.121.243]:17854 "EHLO sender3-op-o12.zoho.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727319AbgCYPL3 (ORCPT ); Wed, 25 Mar 2020 11:11:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1585148957; s=mail; d=flygoat.com; i=jiaxun.yang@flygoat.com; h=Date:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Subject:To:CC:From:Message-ID; bh=UQjW8/R/isr4G+IcObaYVbHnSPnY0ohL2PN+TOGINxU=; b=eEeJkPVLVJ+o14DGDqHn3Y4QG81zbhdA9Byd5TPzBuOYUQVir601pnFe1Y9xiBa/ XpbC7wQHEpzbnLWAR0pXp3pdNw69U9qxlsxrfN5ehRe/+Ka0T2IXkSKcXYy+mnKUHpC AlmmvWmPtl3PERAnKEQmXWoA/zR1Vw4MJqMedAd8= Received: from [10.233.233.252] (183.157.60.227 [183.157.60.227]) by mx.zoho.com.cn with SMTPS id 1585148954458715.120308966621; Wed, 25 Mar 2020 23:09:14 +0800 (CST) Date: Wed, 25 Mar 2020 23:09:10 +0800 User-Agent: K-9 Mail for Android In-Reply-To: <20200325150437.GA14217@alpha.franken.de> References: <20200325035537.156911-1-jiaxun.yang@flygoat.com> <20200325035537.156911-7-jiaxun.yang@flygoat.com> <20200325123742.GA9911@alpha.franken.de> <5eb9ce9ea665ee32da40779f00fc9b37@kernel.org> <4BB367D3-B8AD-47B6-ACC2-30752137BC1B@flygoat.com> <39CF835E-D1D9-4B52-ABDC-BDB17B650936@flygoat.com> <20200325150437.GA14217@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v8 06/11] irqchip: mips-cpu: Convert to simple domain To: Thomas Bogendoerfer CC: Marc Zyngier , linux-mips@vger.kernel.org, Huacai Chen , Thomas Gleixner , Jason Cooper , Rob Herring , Mark Rutland , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Jonathan Cameron , Andy Shevchenko , Allison Randal , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Jiaxun Yang Message-ID: <777D8DAA-F462-4E8D-9012-C114DE6D56DE@flygoat.com> X-ZohoCNMailClient: External Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =E4=BA=8E 2020=E5=B9=B43=E6=9C=8825=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=881= 1:04:37, Thomas Bogendoerfer =E5=86=99=E5= =88=B0: >On Wed, Mar 25, 2020 at 10:31:21PM +0800, Jiaxun Yang wrote: >>=20 >>=20 >> =E4=BA=8E 2020=E5=B9=B43=E6=9C=8825=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D= =8810:15:16, Marc Zyngier =E5=86=99=E5=88=B0: >> >On 2020-03-25 13:59, Jiaxun Yang wrote: >> > >> >[=2E=2E=2E] >> > >> >>>> So probably we can use legacy domain when MIPS IRQ BASE is in >the >> >>>> range of legacy IRQ >> >>>> and switch to simple domain when it's not in that range? >> >>>=20 >> >>> No, see below=2E >> >>>=20 >> >>>> Here in Loongson systems IRQ 0-15 is occupied by I8259 so I did >> >this >> >>>> hack=2E >> >>>=20 >> >>> Well, if you have to consider which Linux IRQ gets assigned, >> >>> then your platform is definitely not ready for non-legacy >> >>> irqdomains=2E Just stick to legacy for now until you have removed >> >>> all the code that knows the hwirq mapping=2E >> >>=20 >> >> Thanks=2E >> >>=20 >> >> So I have to allocate irq_desc here in driver manually? >> > >> >No, you are probably better off just dropping this patch, as MIPS >> >doesn't seem to be ready for a wholesale switch to virtual >interrupts=2E >>=20 >> It can't work without this patch=2E >>=20 >> Legacy domain require IRQ number within 0-15=20 >> however it's already occupied by i8259 or "HTPIC" driver=2E > >what's the problem here ? AFAIK there could be more than one >legacy domain, at least that's what at least IP22/SNI in MIPS world=20 >are doing=2E MIPS_IRQ_BASE must be higher than 15, otherwise it will conflict with i825= 9=2E However we have only preallocated irq_desc for 0-15=2E And legacy domain require irq_desc being preallocated=2E > >Thomas=2E --=20 Jiaxun Yang