From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753420AbdKII3k (ORCPT ); Thu, 9 Nov 2017 03:29:40 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:56832 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751217AbdKII3i (ORCPT ); Thu, 9 Nov 2017 03:29:38 -0500 From: Christian Borntraeger Subject: Re: [PATCH v2] s390/virtio: mark headers as BSD licensed To: "Michael S. Tsirkin" Cc: Cornelia Huck , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Martin Schwidefsky , Heiko Carstens , linux-s390@vger.kernel.org References: <1510160307-13235-1-git-send-email-mst@redhat.com> <9c2debae-5c00-75ad-bc4d-13af9c4f431d@de.ibm.com> <20171108191531.2d2f7210.cohuck@redhat.com> <7ab1b0f9-6db2-1d49-3bc6-320e95c71d5b@de.ibm.com> <5ea37f22-920e-adc9-e7cf-f901faac92db@de.ibm.com> <20171108213424-mutt-send-email-mst@kernel.org> <93547c07-dfab-70d5-6ed6-aada14670406@de.ibm.com> <20171108215816-mutt-send-email-mst@kernel.org> Date: Thu, 9 Nov 2017 09:29:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171108215816-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17110908-0008-0000-0000-000004A95462 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17110908-0009-0000-0000-00001E3BF4A8 Message-Id: <778f7cff-5a67-ce97-3c79-7ae71bb0c696@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-09_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1711090122 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/2017 08:58 PM, Michael S. Tsirkin wrote: > On Wed, Nov 08, 2017 at 08:39:11PM +0100, Christian Borntraeger wrote: >> >> >> On 11/08/2017 08:35 PM, Michael S. Tsirkin wrote: >>> On Wed, Nov 08, 2017 at 07:57:28PM +0100, Christian Borntraeger wrote: >>>> So what about the following >>>> >>>> - leave kvm_virtio.h unchanged and we will delete this file via the s390 tree >>> >>> Seems to be used by kvm_virtio.c - are you removing that too? >> >> Yes, so sorry my first url for the git.kernel.org was in the wrong subfolder: >> https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit?h=features&id=7fb2b2d512448cf0e914c4647a1cf02b52263702 >> >> >>> >>>> - change virtio_ccw.h to BSD license. The content of this file is really really trivial >>>> and it boils down to 2 defines, that can be easily reconstructed by looking at the virtio spec. >>>> Not even sure if something like this can be copyrighted. >>> >>> Yes. What prompted this was Greg's patch. >>> >>>> >>>> For reference the content of this file minus comments is >>>> >>>> - snip - >>>> #define KVM_VIRTIO_CCW_RING_ALIGN 4096 >>>> #define KVM_S390_VIRTIO_CCW_NOTIFY 3 >>>> - snip - >>>> >>>> >> >> [..] > > > So for ccw if both you and Cornelia ACK, we'll be fine I think. > No one else touched this code. A patch that changes virtio_ccw.h to a dual gpl2/bsd licence is Acked-by: Christian Borntraeger as it matches the original intent of the virtio header relicensing from 2008 while at the same time covers the fact that the whole kernel is GPL2.