linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Williams, Dan J" <dan.j.williams@intel.com>
To: "rostedt@goodmis.org" <rostedt@goodmis.org>
Cc: "fweisbec@gmail.com" <fweisbec@gmail.com>,
	"jeyu@kernel.org" <jeyu@kernel.org>,
	"mathieu.desnoyers@efficios.com" <mathieu.desnoyers@efficios.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mingo@elte.hu" <mingo@elte.hu>,
	"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>,
	"yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters
Date: Mon, 19 Apr 2021 21:54:13 +0000	[thread overview]
Message-ID: <77a6e40b57df092d1bd8967305906a210f286111.camel@intel.com> (raw)
In-Reply-To: <20130814233228.778f25d0@gandalf.local.home>

[ drop Rusty, add Jessica and Emmanuel ]

On Wed, 2013-08-14 at 23:32 -0400, Steven Rostedt wrote:
> On Thu, 15 Aug 2013 11:32:10 +0930
> Rusty Russell <rusty@rustcorp.com.au> wrote:
> 
> > Steven Rostedt <rostedt@goodmis.org> writes:
> > > But the thing about this that bothers me is that there's no way
> > > to say,
> > > "Enable all tracepoints in this module on load". I would like a
> > > way to
> > > do that, but I don't know of a way to do that without modifying
> > > the
> > > module code. Have any ideas? Basically, I would love to have:
> > > 
> > > insmod foo tracepoints=all
> > > 
> > > or something and have all tracepoints enabled.
> > 
> > "without modifying the module code"?  Why?  The code isn't that
> > scary,
> > and this seems useful.
> 
> I'm not afraid of the code, I'm afraid of you ;-) I hear you have
> killer puppies.
> 
> 
> OK, then when I get some time, I may cook something up.
> 
> Thanks,
> 
> -- Steve

Revive an old thread...

Steven, did you ever end up with a solution to the "enable tracing at
module load" problem?

I see some people getting admonished to use ftrace over dev_dbg() [1],
but one of the features that keeps dev_dbg() proliferating is its
generic "$mod_name.dyndbg=" module parameter support for selective
debug enabling at boot / module-load.

It would be useful to be able to do
/sys/kernel/debug/dynamic_debug/control enabling for tracepoints, but
also module::function_name patterns for "got here" style debugging. I'd
be happy to help with this, but wanted to understand where you left
things.

[1]: https://lore.kernel.org/linux-wireless/YHRFy3aq%2FgB7Vde6@kroah.com/

  reply	other threads:[~2021-04-19 21:54 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08 22:18 [PATCH][RFC] tracing: Enable tracepoints via module parameters Steven Rostedt
2011-03-08 22:42 ` Steven Rostedt
2011-03-08 23:22 ` Mathieu Desnoyers
2011-03-08 23:32   ` Steven Rostedt
2011-03-09  0:07     ` Mathieu Desnoyers
2011-03-09  0:14       ` Steven Rostedt
2011-03-09  0:29         ` Mathieu Desnoyers
2011-03-09  0:52           ` Steven Rostedt
2011-03-09  1:17             ` Mathieu Desnoyers
2011-03-09  2:01               ` Steven Rostedt
2011-03-09  2:30                 ` Mathieu Desnoyers
2011-03-09  2:01             ` Yuanhan Liu
2011-03-09  2:12               ` Steven Rostedt
2011-03-09  2:19                 ` Yuanhan Liu
2011-03-10 23:33 ` Rusty Russell
2013-08-13 15:14   ` Steven Rostedt
2013-08-13 22:34     ` Mathieu Desnoyers
2013-08-13 23:09       ` Steven Rostedt
2013-08-15  2:02     ` Rusty Russell
2013-08-15  3:32       ` Steven Rostedt
2021-04-19 21:54         ` Williams, Dan J [this message]
2021-04-19 22:11           ` Steven Rostedt
2021-04-20  1:25             ` Dan Williams
2021-04-20 12:55               ` Steven Rostedt
2021-04-20 13:29                 ` Mathieu Desnoyers
2021-04-20 14:55                   ` Steven Rostedt
2021-04-20 15:15                     ` Mathieu Desnoyers
2021-04-20 15:34                       ` Steven Rostedt
2021-04-20 19:54                 ` Dan Williams
2021-04-20 20:32                   ` Steven Rostedt
2021-04-21  6:27                     ` Dan Williams
2021-04-21  7:30                     ` Rasmus Villemoes
2021-04-21 14:20                       ` Steven Rostedt
2021-04-21 14:50                         ` Rasmus Villemoes
2021-04-21 15:00                           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77a6e40b57df092d1bd8967305906a210f286111.camel@intel.com \
    --to=dan.j.williams@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=emmanuel.grumbach@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=jeyu@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).