From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F1A5C432BE for ; Wed, 25 Aug 2021 10:14:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5011061163 for ; Wed, 25 Aug 2021 10:14:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239729AbhHYKPL (ORCPT ); Wed, 25 Aug 2021 06:15:11 -0400 Received: from foss.arm.com ([217.140.110.172]:47702 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239525AbhHYKPJ (ORCPT ); Wed, 25 Aug 2021 06:15:09 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E060931B; Wed, 25 Aug 2021 03:14:23 -0700 (PDT) Received: from [10.57.42.52] (unknown [10.57.42.52]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E12623F66F; Wed, 25 Aug 2021 03:14:21 -0700 (PDT) Subject: Re: [PATCH v2 0/9] Support ETE decoding To: Leo Yan Cc: mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, mike.leach@linaro.org, acme@kernel.org, suzuki.poulose@arm.com, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210806134109.1182235-1-james.clark@arm.com> <20210824084720.GG204566@leoy-ThinkPad-X240s> From: James Clark Message-ID: <77fe6cd4-3e2e-aa60-9aa4-8fa03d08e640@arm.com> Date: Wed, 25 Aug 2021 11:14:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210824084720.GG204566@leoy-ThinkPad-X240s> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/08/2021 09:47, Leo Yan wrote: > Hi Mathieu, Suzuki, Mike, > > On Fri, Aug 06, 2021 at 02:41:00PM +0100, James Clark wrote: >> Changes since v1: >> * Re-implement with a new magic number instead of piggybacking on ETMv4 >> * Improve comments and function name around cs_etm_decoder__get_etmv4_arch_ver() >> * Add a warning for unrecognised magic numbers >> * Split typo fix into new commit >> * Add Leo's reviewed-by tags >> * Create a new struct for ETE config (cs_ete_trace_params) instead of re-using ETMv4 config >> >> Applies to perf/core f3c33cbd922 >> Also available at https://gitlab.arm.com/linux-arm/linux-jc/-/tree/james-ete-v2 > > I have finished the review for this patch series and it's good form for > me. Since this patch series is to enable new feature for ETE, it's > good if any of you could review as well before merging. > Thanks for the reviews Leo! > Thanks, > Leo >