From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75321C47409 for ; Thu, 16 Jan 2020 10:38:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D25C2077B for ; Thu, 16 Jan 2020 10:38:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbgAPKiX (ORCPT ); Thu, 16 Jan 2020 05:38:23 -0500 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:35416 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725800AbgAPKiX (ORCPT ); Thu, 16 Jan 2020 05:38:23 -0500 Received: from [109.168.11.45] (port=50858 helo=[192.168.101.73]) by hostingweb31.netsons.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1is2Xb-00053Y-OV; Thu, 16 Jan 2020 11:38:20 +0100 Subject: Re: [PATCH 26/26] docs: i2c: rename sections so the overall picture is clearer To: Jean Delvare Cc: linux-doc@vger.kernel.org, linux-i2c@vger.kernel.org, Wolfram Sang , Peter Rosin , linux-kernel@vger.kernel.org References: <20200105224006.10321-1-luca@lucaceresoli.net> <20200106074905.14438-1-luca@lucaceresoli.net> <20200116104907.3f2de4d0@endymion> From: Luca Ceresoli Message-ID: <7809c0c2-1d83-cc95-b258-644ea8315f86@lucaceresoli.net> Date: Thu, 16 Jan 2020 11:38:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200116104907.3f2de4d0@endymion> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca+lucaceresoli.net/only user confirmed/virtual account not confirmed X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jean, Peter, thanks both for your reviews. On 16/01/20 10:49, Jean Delvare wrote: > On Mon, 6 Jan 2020 08:49:05 +0100, Luca Ceresoli wrote: >> Some of the section names are not very clear. Reading those names in the >> index.rst page does not help much in grasping what the content is supposed >> to be. >> >> Rename those sections to clarify their content, especially when reading >> the index page. >> >> Signed-off-by: Luca Ceresoli >> Acked-by: Peter Rosin >> --- >> >> Note: here checkpatch complains: >> >> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 >> >> Thas's because those files have no license line. I would gladly add a >> proper license line, but what it the correct license here? Should I ask the >> authors? GPLv2-only as the kernel default? >> >> I'd appreciate a guidance here, thanks in advance. > > I don't think we need a license for such documentation files, so I > would just ignore checkpatch. That's OK for me. >> diff --git a/Documentation/i2c/summary.rst b/Documentation/i2c/summary.rst >> index fc69d9567d9d..ae3bbb9fd8f1 100644 >> --- a/Documentation/i2c/summary.rst >> +++ b/Documentation/i2c/summary.rst >> @@ -1,6 +1,6 @@ >> -============= >> -I2C and SMBus >> -============= >> +============================== >> +Introductions to I2C and SMBus >> +============================== > > I would use "Introduction", singular. Me too! Fix queued for v2. Peter, I assume I can keep your Acked-by in v2 with this small change. -- Luca