linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vijay Khemka <vijaykhemka@fb.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"joel@jms.id.au" <joel@jms.id.au>,
	"andrew@aj.id.au" <andrew@aj.id.au>,
	"afaerber@suse.de" <afaerber@suse.de>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH] ARM: dts: aspeed: Adding Facebook TioagaPass BMC
Date: Fri, 14 Sep 2018 18:57:23 +0000	[thread overview]
Message-ID: <781180F5-B7E7-44CD-9747-8E2908ACF5E2@fb.com> (raw)
In-Reply-To: <20180913201739.GG23892@lunn.ch>

Thanks Andrew,
I have revised patch as I found some more changes. Sent a new version.

Regards
-Vijay

On 9/13/18, 1:18 PM, "Andrew Lunn" <andrew@lunn.ch> wrote:

    > +++ b/arch/arm/boot/dts/Makefile
    > @@ -1206,4 +1206,5 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
    >  	aspeed-bmc-opp-witherspoon.dtb \
    >  	aspeed-bmc-opp-zaius.dtb \
    >  	aspeed-bmc-portwell-neptune.dtb \
    > +	aspeed-bmc-facebook-tiogapass.dtb \
    
    Hi Vijay
    
    These entries are normally kept in alphabetic order.
    
    > +	leds {
    > +		compatible = "gpio-leds";
    > +		postcode0 {
    > +			label="BMC_UP";
    
    Documentation/leds/leds-class.txt
    
    LED Device Naming
    =================
    
    Is currently of the form:
    
    "devicename:colour:function"
    
    	Andrew
    


  reply	other threads:[~2018-09-14 18:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180913195751.1833227-1-vijaykhemka@fb.com>
2018-09-13 20:17 ` [PATCH] ARM: dts: aspeed: Adding Facebook TioagaPass BMC Andrew Lunn
2018-09-14 18:57   ` Vijay Khemka [this message]
2018-09-13 23:11 ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=781180F5-B7E7-44CD-9747-8E2908ACF5E2@fb.com \
    --to=vijaykhemka@fb.com \
    --cc=afaerber@suse.de \
    --cc=andrew@aj.id.au \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).