From: Fabrice Gasnier <fabrice.gasnier@st.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Rob Herring <robh@kernel.org>, <alexandre.torgue@st.com>,
<mark.rutland@arm.com>, <mcoquelin.stm32@gmail.com>,
<lars@metafoo.de>, <knaack.h@gmx.de>, <pmeerw@pmeerw.net>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <benjamin.gaignard@linaro.org>,
<arnaud.pouliquen@st.com>
Subject: Re: [PATCH] iio: adc: stm32-dfsdm: Add support for stm32mp1
Date: Tue, 15 May 2018 17:23:35 +0200 [thread overview]
Message-ID: <781b346a-e457-9c67-2e11-6f6edba88d63@st.com> (raw)
In-Reply-To: <20180512103324.5068c893@archlinux>
On 05/12/2018 11:33 AM, Jonathan Cameron wrote:
> On Mon, 7 May 2018 15:51:51 -0500
> Rob Herring <robh@kernel.org> wrote:
>
>> On Wed, May 02, 2018 at 03:05:23PM +0200, Fabrice Gasnier wrote:
>>> Add support for DFSDM (Digital Filter For Sigma Delta Modulators)
>>> to STM32MP1. This variant is close to STM32H7 DFSDM, it implements
>>> 6 filter instances. Registers map is also increased.
>>>
>>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
>>> ---
>>> .../bindings/iio/adc/st,stm32-dfsdm-adc.txt | 7 +++++--
>>> drivers/iio/adc/stm32-dfsdm-core.c | 21 +++++++++++++++++++++
>>> 2 files changed, 26 insertions(+), 2 deletions(-)
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
> Applied. Whilst doing this I note that I'm getting a few sparse
> warnings for this driver that would be nice to clean up...
>
> CHECK drivers/iio/adc/stm32-dfsdm-adc.c
> drivers/iio/adc/stm32-dfsdm-adc.c:503:21: warning: expression using sizeof(void)
> drivers/iio/adc/stm32-dfsdm-adc.c:503:21: warning: expression using sizeof(void)
>
> Which is mystifying at first glance... Something deep and dirty in the min macro
> but I can't see what..
Hi Jonathan,
I just sent a patch to clean bellow warning. But this is more obscure
regarding min macro...
Many thanks,
Fabrice
>
> drivers/iio/adc/stm32-dfsdm-adc.c:680:5: warning: symbol 'stm32_dfsdm_get_buff_cb' was not declared. Should it be static?
> drivers/iio/adc/stm32-dfsdm-adc.c:703:5: warning: symbol 'stm32_dfsdm_release_buff_cb' was not declared. Should it be static?
>
> Are rather more obvious
>
prev parent reply other threads:[~2018-05-15 15:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 13:05 [PATCH] iio: adc: stm32-dfsdm: Add support for stm32mp1 Fabrice Gasnier
2018-05-06 17:56 ` Jonathan Cameron
2018-05-07 20:51 ` Rob Herring
2018-05-12 9:33 ` Jonathan Cameron
2018-05-15 15:23 ` Fabrice Gasnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=781b346a-e457-9c67-2e11-6f6edba88d63@st.com \
--to=fabrice.gasnier@st.com \
--cc=alexandre.torgue@st.com \
--cc=arnaud.pouliquen@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).