From: Dave Hansen <dave.hansen@intel.com>
To: Jon Kohler <jon@nutanix.com>
Cc: Babu Moger <babu.moger@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Yu-cheng Yu <yu-cheng.yu@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Tony Luck <tony.luck@intel.com>, Uros Bizjak <ubizjak@gmail.com>,
Petteri Aimonen <jpa@git.mail.kapsi.fi>,
Al Viro <viro@zeniv.linux.org.uk>,
Kan Liang <kan.liang@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>, Fan Yang <Fan_Yang@sjtu.edu.cn>,
Juergen Gross <jgross@suse.com>,
Benjamin Thiel <b.thiel@posteo.de>,
Dave Jiang <dave.jiang@intel.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
Arvind Sankar <nivedita@alum.mit.edu>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v3] KVM: x86: use wrpkru directly in kvm_load_{guest|host}_xsave_state
Date: Tue, 11 May 2021 12:08:44 -0700 [thread overview]
Message-ID: <7820b622-fcb2-ea59-c0b0-a3c52ac8e3e8@intel.com> (raw)
In-Reply-To: <20210511170508.40034-1-jon@nutanix.com>
On 5/11/21 10:05 AM, Jon Kohler wrote:
> To improve performance, use wrpkru directly in KVM code and simplify
> the uses of __write_pkru such that it can be removed completely.
I don't love the repeated:
+ if (pkru_val != rdpkru())
+ wrpkru(pkru_val);
But, all of the w*pkru() variants were getting confusing, even to me. :)
Being explicit about the "wkpkru suppression" in a limited number of
places looks fine.
Acked-by: Dave Hansen <dave.hansen@intel.com>
next prev parent reply other threads:[~2021-05-11 19:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 17:05 [PATCH v3] KVM: x86: use wrpkru directly in kvm_load_{guest|host}_xsave_state Jon Kohler
2021-05-11 19:08 ` Dave Hansen [this message]
2021-05-12 7:41 ` Peter Zijlstra
2021-05-12 18:33 ` Dave Hansen
[not found] ` <1bde6f22-166b-8552-e7f3-5731508182ea@kernel.org>
2021-05-17 2:58 ` Jon Kohler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7820b622-fcb2-ea59-c0b0-a3c52ac8e3e8@intel.com \
--to=dave.hansen@intel.com \
--cc=Fan_Yang@sjtu.edu.cn \
--cc=akpm@linux-foundation.org \
--cc=b.thiel@posteo.de \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=dave.jiang@intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jmattson@google.com \
--cc=jon@nutanix.com \
--cc=joro@8bytes.org \
--cc=jpa@git.mail.kapsi.fi \
--cc=kan.liang@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nivedita@alum.mit.edu \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=ubizjak@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).