linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* alpha: Checking for a failed kmalloc() in process_reloc_for_got()?
@ 2016-12-03 13:15 SF Markus Elfring
  2016-12-04  0:10 ` Jiri Kosina
  0 siblings, 1 reply; 3+ messages in thread
From: SF Markus Elfring @ 2016-12-03 13:15 UTC (permalink / raw)
  To: linux-alpha, Jiri Kosina, Josh Poimboeuf, Matt Turner,
	Peter Zijlstra, Richard Henderson, Rusty Russell
  Cc: kernel-janitors, linux-kernel

Hello,

Another run of a small script for the semantic patch language (Coccinelle)
pointed the implementation of the function “process_reloc_for_got” out for
further considerations.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/alpha/kernel/module.c?id=e05f574a0bb1f4502a4b2264fdb0ef6419cf3772#n40

Would it be useful to check the return value from a call of the
function “kmalloc” also there?

Regards,
Markus

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: alpha: Checking for a failed kmalloc() in process_reloc_for_got()?
  2016-12-03 13:15 alpha: Checking for a failed kmalloc() in process_reloc_for_got()? SF Markus Elfring
@ 2016-12-04  0:10 ` Jiri Kosina
  2016-12-04 10:20   ` SF Markus Elfring
  0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2016-12-04  0:10 UTC (permalink / raw)
  To: SF Markus Elfring
  Cc: linux-alpha, Josh Poimboeuf, Matt Turner, Peter Zijlstra,
	Richard Henderson, Rusty Russell, kernel-janitors, linux-kernel

On Sat, 3 Dec 2016, SF Markus Elfring wrote:

> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/alpha/kernel/module.c?id=e05f574a0bb1f4502a4b2264fdb0ef6419cf3772#n40
> 
> Would it be useful to check the return value from a call of the
> function “kmalloc” also there?

*drumroll* it'd actually be a proper bugfix.

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: alpha: Checking for a failed kmalloc() in process_reloc_for_got()?
  2016-12-04  0:10 ` Jiri Kosina
@ 2016-12-04 10:20   ` SF Markus Elfring
  0 siblings, 0 replies; 3+ messages in thread
From: SF Markus Elfring @ 2016-12-04 10:20 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: linux-alpha, Josh Poimboeuf, Matt Turner, Peter Zijlstra,
	Richard Henderson, Rusty Russell, kernel-janitors, linux-kernel

>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/alpha/kernel/module.c?id=e05f574a0bb1f4502a4b2264fdb0ef6419cf3772#n40
>>
>> Would it be useful to check the return value from a call of the
>> function “kmalloc” also there?
> 
> *drumroll* it'd actually be a proper bugfix.

Which kind of exception handling can be added here when the function
“process_reloc_for_got” has got the return type “void” so far?

Will it be needed to handle such a software failure at more source code places
by a special error code?

Regards,
Markus

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-12-04 10:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-03 13:15 alpha: Checking for a failed kmalloc() in process_reloc_for_got()? SF Markus Elfring
2016-12-04  0:10 ` Jiri Kosina
2016-12-04 10:20   ` SF Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).