linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: cluster-devel <cluster-devel@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: GFS2: Pull request (merge window)
Date: Fri, 22 Jul 2016 13:33:47 -0400 (EDT)	[thread overview]
Message-ID: <782547260.17300905.1469208827592.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <404724578.17300814.1469208769730.JavaMail.zimbra@redhat.com>

Hi Linus,

Please consider pulling the following changes for the GFS2 file system.

Since I'll be on vacation / holiday all next week, I'm doing the merge
window processing for GFS2 early this time, before the merge window has
been officially opened: I'd rather post the patches a little early than
delay it until I return, then be late and have you be unhappy with me
as a maintainer.

Also, I apologize that the last patch, "GFS2: Fix gfs2_replay_incr_blk
for multiple journal sizes" hasn't had much bake time. The patch is
straightforward, reviewed, and well tested with a reliable recreation
scenario. Since the bug prevents users from mounting their GFS2 file
system, I wanted to get it in as soon as possible. I felt that the need
outweighed other concerns.

Since I'll be on vacation next week, Andreas Gruenbacher can make changes
to the linux-gfs2 repo if need be.

Bob Peterson

----------------------------------------------------------------
The following changes since commit 29567292c0b5b2fb484125c280a2175141fe2205:

  Merge tag 'for-linus-4.7-rc0-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip (2016-05-24 10:22:34 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-4.7.fixes

for you to fetch changes up to e1cb6be9e142e6cc6246f3ab2776b4d7a2b3d9f0:

  GFS2: Fix gfs2_replay_incr_blk for multiple journal sizes (2016-07-21 13:02:44 -0500)

----------------------------------------------------------------
We've got ten patches this time, half of which are related to a plethora
of nasty outcomes when inodes are transitioned from the unlinked state
to the free state. Small file systems are particularly vulnerable to these
problems, and it can manifest as mainly hangs, but also file system
corruption. The patches have been tested for literally many weeks, with a
very gruelling test, so I have a high level of confidence.

- Andreas Gruenbacher wrote a series of 5 patches for various lockups
  during the transition of inodes from unlinked to free. The main patch
  is titled "Fix gfs2_lookup_by_inum lock inversion" and the other 4 are
  support and cleanup patches related to that.
- Ben Marzinski contributed 2 patches with regard to a recreatable
  problem when gfs2 tries to write a page to a file that is being
  truncated, resulting in a BUG() in gfs2_remove_from_journal.
  Note that Ben had to export vfs function __block_write_full_page to get
  this to work properly. It's been posted a long time and he talked to
  various VFS people about it, and nobody seemed to mind.
- I contributed 3 patches. (1) The first one fixes a memory corruptor:
  a race in which one process can overwrite the gl_object pointer set by
  another process, causing kernel panic and other symptoms. (2) The second
  patch fixes another race that resulted in a false-positive BUG_ON. This
  occurred when resource group reservations were freed by one process
  while another process was trying to grab a new reservation in the same
  resource group. (3) The third patch fixes a problem with doing journal
  replay when the journals are not all the same size.

----------------------------------------------------------------
Andreas Gruenbacher (5):
      gfs2: Initialize iopen glock holder for new inodes
      gfs2: Fix gfs2_lookup_by_inum lock inversion
      gfs2: Get rid of gfs2_ilookup
      gfs2: Large-filesystem fix for 32-bit systems
      gfs2: Lock holder cleanup

Benjamin Marzinski (2):
      fs: export __block_write_full_page
      gfs2: writeout truncated pages

Bob Peterson (3):
      GFS2: don't set rgrp gl_object until it's inserted into rgrp tree
      GFS2: Check rs_free with rd_rsspin protection
      GFS2: Fix gfs2_replay_incr_blk for multiple journal sizes

 fs/buffer.c                 |   3 +-
 fs/gfs2/aops.c              |  49 +++++++++++------
 fs/gfs2/dentry.c            |   2 +-
 fs/gfs2/dir.c               |   3 +-
 fs/gfs2/export.c            |  11 ----
 fs/gfs2/file.c              |   2 +-
 fs/gfs2/glock.c             |  11 +---
 fs/gfs2/glock.h             |  10 ++++
 fs/gfs2/inode.c             | 128 +++++++++++++++++++++++++++++---------------
 fs/gfs2/inode.h             |   4 +-
 fs/gfs2/lops.c              |  11 ++--
 fs/gfs2/main.c              |   1 +
 fs/gfs2/ops_fstype.c        |   3 +-
 fs/gfs2/quota.c             |   2 +-
 fs/gfs2/recovery.c          |   6 +--
 fs/gfs2/recovery.h          |   4 +-
 fs/gfs2/rgrp.c              |  21 ++++----
 fs/gfs2/super.c             |  24 +++++----
 include/linux/buffer_head.h |   3 ++
 19 files changed, 182 insertions(+), 116 deletions(-)

       reply	other threads:[~2016-07-22 17:33 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <404724578.17300814.1469208769730.JavaMail.zimbra@redhat.com>
2016-07-22 17:33 ` Bob Peterson [this message]
     [not found] <2063498114.10752149.1552067836491.JavaMail.zimbra@redhat.com>
2019-03-08 17:58 ` GFS2: Pull request (merge window) Bob Peterson
     [not found] <180051537.56890898.1545229879645.JavaMail.zimbra@redhat.com>
2018-12-19 14:31 ` Bob Peterson
     [not found] <1929897739.23623737.1540322729596.JavaMail.zimbra@redhat.com>
2018-10-23 19:26 ` Bob Peterson
2018-10-24 16:35   ` Linus Torvalds
2018-10-24 16:41     ` Bob Peterson
     [not found] <1772901878.39899227.1528134744434.JavaMail.zimbra@redhat.com>
2018-06-04 17:53 ` Bob Peterson
     [not found] <242799785.15741010.1522776740239.JavaMail.zimbra@redhat.com>
2018-04-03 17:32 ` Bob Peterson
     [not found] <2035999397.5567269.1517410350526.JavaMail.zimbra@redhat.com>
2018-01-31 14:54 ` Bob Peterson
     [not found] <800692691.31850756.1510678641181.JavaMail.zimbra@redhat.com>
2017-11-14 16:57 ` Bob Peterson
2017-11-14 17:17   ` Bob Peterson
     [not found] <1332965725.6958432.1504544624096.JavaMail.zimbra@redhat.com>
2017-09-04 17:05 ` Bob Peterson
     [not found] <2018468119.28735933.1499259957760.JavaMail.zimbra@redhat.com>
2017-07-05 13:08 ` Bob Peterson
     [not found] <909713995.4565875.1494016018520.JavaMail.zimbra@redhat.com>
2017-05-05 20:28 ` Bob Peterson
2017-05-05 21:07   ` Linus Torvalds
     [not found] <1526627784.3659456.1493822813354.JavaMail.zimbra@redhat.com>
2017-05-03 16:41 ` Bob Peterson
     [not found] <468087826.25173671.1487684421990.JavaMail.zimbra@redhat.com>
2017-02-21 13:41 ` Bob Peterson
     [not found] <603920106.687778.1475513554626.JavaMail.zimbra@redhat.com>
2016-10-03 16:55 ` Bob Peterson
     [not found] <2074855986.8621406.1463772170266.JavaMail.zimbra@redhat.com>
2016-05-20 19:23 ` Bob Peterson
     [not found] <2094757318.39162844.1458219077321.JavaMail.zimbra@redhat.com>
2016-03-17 12:51 ` Bob Peterson
     [not found] <1243871936.8427302.1452623511952.JavaMail.zimbra@redhat.com>
2016-01-12 18:34 ` Bob Peterson
     [not found] <337313427.7367463.1447086799887.JavaMail.zimbra@redhat.com>
2015-11-09 16:45 ` Bob Peterson
     [not found] <987432592.26261269.1441889826020.JavaMail.zimbra@redhat.com>
2015-09-10 13:19 ` Bob Peterson
     [not found] <1946368926.25134466.1435330524247.JavaMail.zimbra@redhat.com>
2015-06-26 14:56 ` Bob Peterson
     [not found] <1305736412.15685734.1429033600005.JavaMail.zimbra@redhat.com>
2015-04-14 17:47 ` Bob Peterson
2015-04-14 23:16   ` Linus Torvalds
2015-04-15  7:34     ` Steven Whitehouse
2015-04-14 23:19   ` Linus Torvalds
2015-04-15 12:09     ` Bob Peterson
2015-02-10 11:04 Steven Whitehouse
  -- strict thread matches above, loose matches on Subject: below --
2014-12-08 18:26 Steven Whitehouse
2014-10-08 19:25 Steven Whitehouse
2014-06-04  9:33 Steven Whitehouse
2014-04-01 23:15 Steven Whitehouse
2014-04-04 21:52 ` Linus Torvalds
2014-04-07  9:31   ` Steven Whitehouse
2014-01-20 19:15 Steven Whitehouse
2013-11-05 15:39 Steven Whitehouse
2013-09-09  9:22 Steven Whitehouse
2013-07-01 15:20 Steven Whitehouse
2013-04-29 11:08 Steven Whitehouse
2013-02-19 16:38 Steven Whitehouse
2012-12-11 10:39 Steven Whitehouse
2012-09-13 13:42 GFS2: Pull request (fixes) Steven Whitehouse
2012-10-01  9:09 ` GFS2: Pull request (merge window) Steven Whitehouse
2012-07-23 14:59 Steven Whitehouse
2012-08-03  1:22 ` Linus Torvalds
2012-08-03 10:18   ` Steven Whitehouse
2012-08-03 16:16     ` Linus Torvalds
2012-05-21  8:17 Steven Whitehouse
2012-03-20 16:10 Steven Whitehouse
2012-01-06 12:09 Steven Whitehouse
2011-10-25  8:41 Steven Whitehouse
2011-07-22 12:08 Steven Whitehouse
2011-05-20  8:14 Steven Whitehouse
2011-03-16 13:55 Steven Whitehouse
2011-01-05 10:22 Steven Whitehouse
2010-10-21  9:43 Steven Whitehouse
2010-08-03  9:06 Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=782547260.17300905.1469208827592.JavaMail.zimbra@redhat.com \
    --to=rpeterso@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).