From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH v5] f2fs: fix performance issue observed with multi-thread sequential read
Date: Tue, 21 Aug 2018 11:30:22 +0800 [thread overview]
Message-ID: <782a0bae-a398-9afe-745e-cca31e8fc8e8@huawei.com> (raw)
In-Reply-To: <20180821023626.GB20263@jaegeuk-macbookpro.roam.corp.google.com>
On 2018/8/21 10:36, Jaegeuk Kim wrote:
> This reverts the commit - "b93f771 - f2fs: remove writepages lock"
> to fix the drop in sequential read throughput.
>
> Test: ./tiotest -t 32 -d /data/tio_tmp -f 32 -b 524288 -k 1 -k 3 -L
> device: UFS
>
> Before -
> read throughput: 185 MB/s
> total read requests: 85177 (of these ~80000 are 4KB size requests).
> total write requests: 2546 (of these ~2208 requests are written in 512KB).
>
> After -
> read throughput: 758 MB/s
> total read requests: 2417 (of these ~2042 are 512KB reads).
> total write requests: 2701 (of these ~2034 requests are written in 512KB).
>
> Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> Change log from v4:
> - add __should_serialize_io
> - fix wrong condition
>
> Documentation/ABI/testing/sysfs-fs-f2fs | 8 ++++++++
> fs/f2fs/data.c | 21 +++++++++++++++++++++
> fs/f2fs/f2fs.h | 2 ++
> fs/f2fs/segment.c | 1 +
> fs/f2fs/super.c | 1 +
> fs/f2fs/sysfs.c | 2 ++
> 6 files changed, 35 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs
> index 9b0123388f18..94a24aedcdb2 100644
> --- a/Documentation/ABI/testing/sysfs-fs-f2fs
> +++ b/Documentation/ABI/testing/sysfs-fs-f2fs
> @@ -51,6 +51,14 @@ Description:
> Controls the dirty page count condition for the in-place-update
> policies.
>
> +What: /sys/fs/f2fs/<disk>/min_seq_blocks
> +Date: August 2018
> +Contact: "Jaegeuk Kim" <jaegeuk@kernel.org>
> +Description:
> + Controls the dirty page count condition for batched sequential
> + writes in ->writepages.
> +
> +
> What: /sys/fs/f2fs/<disk>/min_hot_blocks
> Date: March 2017
> Contact: "Jaegeuk Kim" <jaegeuk@kernel.org>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 43d3723dc886..bdcb023506a7 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -2122,6 +2122,18 @@ static int f2fs_write_cache_pages(struct address_space *mapping,
> return ret;
> }
>
> +static inline bool __should_serialize_io(struct inode *inode,
> + struct writeback_control *wbc)
> +{
> + if (!S_ISREG(inode->i_mode))
Good catch! Will be better. :)
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
prev parent reply other threads:[~2018-08-21 3:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 2:37 [PATCH] f2fs: fix performance issue observed with multi-thread sequential read Jaegeuk Kim
2018-08-10 2:48 ` [PATCH v2] " Jaegeuk Kim
2018-08-10 18:56 ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim
2018-08-13 2:20 ` Chao Yu
2018-08-13 20:11 ` Jaegeuk Kim
2018-08-14 3:49 ` Chao Yu
2018-08-14 4:04 ` Jaegeuk Kim
2018-08-14 6:18 ` Chao Yu
2018-08-14 17:28 ` Jaegeuk Kim
2018-08-15 1:52 ` Chao Yu
2018-08-15 2:15 ` Jaegeuk Kim
2018-08-15 3:44 ` Chao Yu
2018-08-16 1:34 ` Jaegeuk Kim
2018-08-16 11:39 ` Chao Yu
2018-08-17 18:29 ` [f2fs-dev] [PATCH v4] " Jaegeuk Kim
2018-08-20 1:21 ` Chao Yu
2018-08-21 2:28 ` Jaegeuk Kim
2018-08-21 3:26 ` Chao Yu
2018-08-21 2:36 ` [f2fs-dev] [PATCH v5] " Jaegeuk Kim
2018-08-21 3:30 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=782a0bae-a398-9afe-745e-cca31e8fc8e8@huawei.com \
--to=yuchao0@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).