From: Yuehaibing <yuehaibing@huawei.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: <knaack.h@gmx.de>, <lars@metafoo.de>, <pmeerw@pmeerw.net>,
<denis.ciocca@st.com>, <tglx@linutronix.de>,
<alexios.zavras@intel.com>, <allison@lohutok.net>,
<linus.walleij@linaro.org>, <ladis@linux-mips.org>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 -next] iio: st_accel: Fix unused variable warning
Date: Mon, 18 Nov 2019 09:41:37 +0800 [thread overview]
Message-ID: <782ac6a6-9ee6-38fa-c599-72da7f70ffa5@huawei.com> (raw)
In-Reply-To: <20191116145821.1ac46310@archlinux>
On 2019/11/16 22:58, Jonathan Cameron wrote:
> On Mon, 11 Nov 2019 11:21:15 +0800
> YueHaibing <yuehaibing@huawei.com> wrote:
>
>> drivers/iio/accel/st_accel_core.c:1005:44: warning:
>> mount_matrix_ext_info defined but not used [-Wunused-const-variable=]
>>
>> Using stub helper while CONFIG_ACPI is disabled to fix it.
>>
>> Suggested-by: Ladislav Michl <ladis@linux-mips.org>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Applied to the fixes-togreg branch of iio.git as I've now closed for new
> things for the coming merge window. This will go upstream after the merge
> window closes and probably hit around rc2. Thanks for cleaning this up.
Thanks!
>
> Jonathan
>
>> ---
>> drivers/iio/accel/st_accel_core.c | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c
>> index 7b83764..7320275 100644
>> --- a/drivers/iio/accel/st_accel_core.c
>> +++ b/drivers/iio/accel/st_accel_core.c
>> @@ -992,6 +992,7 @@ static const struct iio_trigger_ops st_accel_trigger_ops = {
>> #define ST_ACCEL_TRIGGER_OPS NULL
>> #endif
>>
>> +#ifdef CONFIG_ACPI
>> static const struct iio_mount_matrix *
>> get_mount_matrix(const struct iio_dev *indio_dev,
>> const struct iio_chan_spec *chan)
>> @@ -1012,7 +1013,6 @@ static const struct iio_chan_spec_ext_info mount_matrix_ext_info[] = {
>> static int apply_acpi_orientation(struct iio_dev *indio_dev,
>> struct iio_chan_spec *channels)
>> {
>> -#ifdef CONFIG_ACPI
>> struct st_sensor_data *adata = iio_priv(indio_dev);
>> struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
>> struct acpi_device *adev;
>> @@ -1140,10 +1140,14 @@ static int apply_acpi_orientation(struct iio_dev *indio_dev,
>> out:
>> kfree(buffer.pointer);
>> return ret;
>> +}
>> #else /* !CONFIG_ACPI */
>> +static int apply_acpi_orientation(struct iio_dev *indio_dev,
>> + struct iio_chan_spec *channels)
>> +{
>> return 0;
>> -#endif
>> }
>> +#endif
>>
>> /*
>> * st_accel_get_settings() - get sensor settings from device name
>
>
> .
>
prev parent reply other threads:[~2019-11-18 1:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 13:47 [PATCH -next] iio: st_accel: Fix unused variable warning YueHaibing
2019-11-02 10:41 ` Ladislav Michl
2019-11-02 14:08 ` Jonathan Cameron
2019-11-02 20:15 ` Ladislav Michl
2019-11-03 11:01 ` Jonathan Cameron
2019-11-04 1:29 ` Yuehaibing
2019-11-09 11:50 ` Jonathan Cameron
2019-11-11 3:21 ` [PATCH v2 " YueHaibing
2019-11-16 14:58 ` Jonathan Cameron
2019-11-18 1:41 ` Yuehaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=782ac6a6-9ee6-38fa-c599-72da7f70ffa5@huawei.com \
--to=yuehaibing@huawei.com \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=denis.ciocca@st.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=ladis@linux-mips.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).