From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965289AbcFMJXN (ORCPT ); Mon, 13 Jun 2016 05:23:13 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:51523 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964844AbcFMJXM (ORCPT ); Mon, 13 Jun 2016 05:23:12 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Andrey Smirnov , Shawn Guo , Russell King , linux-kernel@vger.kernel.org, Sascha Hauer Subject: Re: [PATCH 3/3] i.MX: system.c: Replace magic numbers Date: Mon, 13 Jun 2016 11:24:02 +0200 Message-ID: <7839599.pSVM3KJL9Z@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1465797329-22537-3-git-send-email-andrew.smirnov@gmail.com> References: <1465797329-22537-1-git-send-email-andrew.smirnov@gmail.com> <1465797329-22537-3-git-send-email-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:od9Orxua0HgVwRf4EycLLJSnYrSlmQPQv3dDil56PNEkGfp8fK0 wx+1EJ84LtvKVnU8XPi4LXYWijf3bYbuBz4qfOlWbvl2bxY/tNMPTvdA72CqDd3SF8+XjLl GuDMPObyemjYu8O1GcM/jxnxxDqFz+o9TQbDfQ58ClwJBuRLkOVIS+Gb1odskvbjZPYbdhE VPUgucuzMaIjq9gmU3cEg== X-UI-Out-Filterresults: notjunk:1;V01:K0:4mX5Alm0ehg=:kPX7yfSvCWSV0BPe1+6xea pc77pnq/8JcaP9B62LkFnGOFFPS/ZHSdTmGnZ5LzoRlrF1dnOytnNm0xxppQBsTWwhYoO+gye tge97icmjXfGlu0IrmIsJCFcqhDdPdnBqjoPBk9ZrrFNKN4Z46a3BsnToEUwqWPh3fknOf77/ vmcLmaFlPcA3sIEBXSI+MymnBiA9UBqma6vQOswG0T601OTS9UE7SNebzlXT0OHv0KIdQK053 bc66xOSQuPrwm27Ir+YCHxsCCT9zAbb5OgNLGwlwIRl6S7GTO/DFeYP945ttqshlEC7r/9Mg8 IUTU4uaCbkW7SJ5i13EluOFCo3XMOAkTLrjnX6OeiLB1cX62ZuCxgPxpjt6vzYfWdPOu/rzFY gXQz/WybGhNlbCi2g90UkV3VOYp1rHItduTaae5WX/P2zLoxK9nQXZLyVSEBuFRrzn76jNLcp t+LSEwdIH9I7KA42dQ5MptsvdzOHIf4ck1/pZc1Hz188GGS5DVqO4LmUNlRKMZVgEDCNCygbB nwl/CoNaOCcS6G4MfL+BpDjr0hb4gly0/HmQQdTqgug0Sum8XOBMEjvrf4AsiMjOV/+w7wtoq Jvs3gIlCGJ+chYVgZrtL1vrVMWfCsHXcwq15KEeS6W156TPyJ2KUVrF89wKcnSLp6PJyf6nK8 DhzCWaXcGfLGxpbemSGnlC/etM6jH/LD+CX0SqXDGO8xEi1HgT6pXWzZIc4PNuJ/xJmJ9y6Hg EMuTZzGp8ZZQ1wTV Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, June 12, 2016 10:55:29 PM CEST Andrey Smirnov wrote: > @@ -61,6 +61,13 @@ > #define L2X0_LINE_TAG 0xF30 > #define L2X0_DEBUG_CTRL 0xF40 > #define L310_PREFETCH_CTRL 0xF60 > +#define L310_DOUBLE_LINEFILL_EN BIT(30) > +#define L310_INSTRUCTION_PREFETCH_EN BIT(29) > +#define L310_DATA_PREFETCH_EN BIT(28) > +#define L310_DOUBLE_LINEFILL_ON_WRAP_READ_DIS BIT(27) > +#define L310_PREFETCH_DROP_EN BIT(24) > +#define L310_INCR_DOUBLE_LINEFILL_EN BIT(23) > +#define L310_ESCLUSIVE_SEQUENCE_EN BIT(21) > #define L310_POWER_CTRL 0xF80 > #define L310_DYNAMIC_CLK_GATING_EN (1 << 1) > #define L310_STNDBY_MODE_EN (1 << 0) > diff --git a/arch/arm/mach-imx/system.c b/arch/arm/mach-imx/system.c > Most of these macros seem to all exist further down in the file already under slightly differnet names, e.g. #define L310_PREFETCH_CTRL_DBL_LINEFILL_INCR BIT(23) Arnd