From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF344C433DF for ; Mon, 15 Jun 2020 07:43:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B42462068E for ; Mon, 15 Jun 2020 07:43:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728701AbgFOHnS (ORCPT ); Mon, 15 Jun 2020 03:43:18 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:5827 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728260AbgFOHnS (ORCPT ); Mon, 15 Jun 2020 03:43:18 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 3F70A45BD575FDFD01CC; Mon, 15 Jun 2020 15:43:13 +0800 (CST) Received: from [127.0.0.1] (10.166.213.7) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Mon, 15 Jun 2020 15:43:09 +0800 Subject: Re: [PATCH] erofs: Eliminate usage of uninitialized_var() macro To: Gao Xiang CC: , , , , , Kees Cook , References: <20200615040141.3627746-1-yanaijie@huawei.com> <20200615072521.GA25317@xiangao.remote.csb> From: Jason Yan Message-ID: <783fe4f9-fb1f-7f5e-c900-7e30d5c85222@huawei.com> Date: Mon, 15 Jun 2020 15:43:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200615072521.GA25317@xiangao.remote.csb> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.166.213.7] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2020/6/15 15:25, Gao Xiang дµÀ: > Hi Jason, > > On Mon, Jun 15, 2020 at 12:01:41PM +0800, Jason Yan wrote: >> This is an effort to eliminate the uninitialized_var() macro[1]. >> >> The use of this macro is the wrong solution because it forces off ANY >> analysis by the compiler for a given variable. It even masks "unused >> variable" warnings. >> >> Quoted from Linus[2]: >> >> "It's a horrible thing to use, in that it adds extra cruft to the >> source code, and then shuts up a compiler warning (even the _reliable_ >> warnings from gcc)." >> >> The gcc option "-Wmaybe-uninitialized" has been disabled and this change >> will not produce any warnnings even with "make W=1". >> >> [1] https://github.com/KSPP/linux/issues/81 >> [2] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/ >> >> Cc: Kees Cook >> Cc: Chao Yu >> Signed-off-by: Jason Yan >> --- > > I'm fine with the patch since "-Wmaybe-uninitialized" has been disabled and > I've also asked Kees for it in private previously. > > I still remembered that Kees sent out a treewide patch. Sorry about that > I don't catch up it... But what is wrong with the original patchset? > Yes, Kees has remind me of that and I will let him handle it. So you can ignore this patch. Thanks, Jason > Thanks, > Gao Xiang > > > . >