linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: William Breathitt Gray <vilhelm.gray@gmail.com>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: 104-quad-8: Fix index control configuration
Date: Sat, 3 Dec 2016 10:02:19 +0000	[thread overview]
Message-ID: <784965ac-6181-d64e-a44f-b06f2e9510fa@kernel.org> (raw)
In-Reply-To: <20161128212244.GA6655@sophia>

On 28/11/16 21:22, William Breathitt Gray wrote:
> The LS7266R1 requires bits 5 & 6 to be high in order to select the Index
> Control Register. This patch fixes a typo that incorrectly selects the
> Input/Output Control Register where the Index Control Register was
> desired.
> 
> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Applied to the fixes-togreg-post-rc1 branch and marked for stable
(though that is probably irrelevant given this didn't apply to my fixes-togreg tree.

Jonathan
> ---
>  drivers/iio/counter/104-quad-8.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
> index 2d2ee35..c0a69d7 100644
> --- a/drivers/iio/counter/104-quad-8.c
> +++ b/drivers/iio/counter/104-quad-8.c
> @@ -362,7 +362,7 @@ static int quad8_set_synchronous_mode(struct iio_dev *indio_dev,
>  	priv->synchronous_mode[chan->channel] = synchronous_mode;
>  
>  	/* Load Index Control configuration to Index Control Register */
> -	outb(0x40 | idr_cfg, base_offset);
> +	outb(0x60 | idr_cfg, base_offset);
>  
>  	return 0;
>  }
> @@ -444,7 +444,7 @@ static int quad8_set_index_polarity(struct iio_dev *indio_dev,
>  	priv->index_polarity[chan->channel] = index_polarity;
>  
>  	/* Load Index Control configuration to Index Control Register */
> -	outb(0x40 | idr_cfg, base_offset);
> +	outb(0x60 | idr_cfg, base_offset);
>  
>  	return 0;
>  }
> 

      reply	other threads:[~2016-12-03 14:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 21:22 [PATCH] iio: 104-quad-8: Fix index control configuration William Breathitt Gray
2016-12-03 10:02 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=784965ac-6181-d64e-a44f-b06f2e9510fa@kernel.org \
    --to=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=vilhelm.gray@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).